-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hugging Face #9259
Add Hugging Face #9259
Conversation
Had opened #9256 and just noticed this 😅 |
Did you want to contribute? I didn't understand. 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this treatment, though the SVG path should fill the 24x24 viewbox. Could you update this one please @PratyushJayachandran? 🙏
Oops... don't know how that slipped through linter :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finding it difficult to auto simplify without losing shape |
Ew! Far too many points! 😆 @PratyushJayachandran, could you give it another go with the SVG in the website header? It's a little bit cleaner. |
I redid it from the source you attached and changed the source in JSON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PratyushJayachandran - I'm seeing some differences between the header icon and your PR, potentially just a precision thing?
I upped the precision, please take another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still seeing those same differences, @PratyushJayachandran 🤔 As well as some minor ones on the right side of the mouth.
I redid the icon but I am somehow ending up with a lot of points on the mouth part. I tried to do it in different ways but my program always produces those excess points. |
Your current version lines up perfectly with the source, @PratyushJayachandran; nice work. Had a go at cleaning up some of the excess points and came up with the below. Damn near drove me blind so it'll need to be optimised and compared with the original again.
|
Should I redo with your paths? You did a lot of heavy lifting 😝 |
Any updates on this? Would love to see this merged. |
Updated the icon based on the new (almost) monochrome icon @adamjstewart pointed out is now available on their brand page. It's much cleaner than anything we've tried to work off before but still has quite a few excess points and is very fiddly to work with. I did my best to strike a happy medium between removing points and staying as faithful as I could to the source, but there will likely be a few tiny differences as a result, but I'd be happy with that trade-off. |
@PeterShaggyNoble we should put a stroke on the bottom part of the face like the original preview image on this PR. |
Having now seen their own (almost) monochrome treatment, I no longer think it's necessary. But, if anyone else feels differently then here's an unoptimised path with it included:
|
FWIW, I like it better with the line under the mouth. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this treatment for now, hopefully they release a truly monochrome version of their icon in the near future... Thanks @PratyushJayachandran and @PeterShaggyNoble 🎉
…enamed icons (v12.0.0) ## New Icons - Audiobookshelf (#10605) (@21st-centuryman) - Awwwards (#10539) (@stefanobartoletti) - Foundry Virtual Tabletop (#10575) (@adamrusted) - FusionAuth (#10776) (@service-paradis) - Homepage (#10452) (@21st-centuryman) - Hugging Face (#9259) (@PratyushJayachandran) - Kagi (#10976) (@uncenter) - n8n (#10909) (@CodeShakingSheep) - Posit (#10987) (@cwickham) - React Bootstrap (#10921) (@CodeShakingSheep) - Sartorius (#10967) (@CodeShakingSheep) - UiPath (#10773) (@Mvlprem) - unpkg (#10317) (@service-paradis) - Zigbee2MQTT (#10212) (@PeterShaggyNoble) ## Updated Icons - Adidas (#10982) (@jglamp) - FastAPI (#10663) (@uncenter) - RenovateBot (#10996) (@sisp) ## Removed Icons - FITE (#10060) (@PeterShaggyNoble) - Flattr (#10380) (@service-paradis) - Google Bard (#10453) (@PeterShaggyNoble) - Integromat (#10152) (@PeterShaggyNoble) - Niantic (#10979) (@PratyushJayachandran) - Nintendo Network (#10006) (@adamrusted) - Rome (#10113) (@PeterShaggyNoble) - Shotcut (#10043) (@PeterShaggyNoble) - Skynet (#10504) (@kwypchlo) - Twitter (#9748) (@adamrusted) ## Renamed Icons - `Airbrake.io` to `Airbrake` (#10513) (@PeterShaggyNoble) - `Amazon Web Services` to `Amazon Web Services` (#10391) (@readboy8) - `RStudio` to `RStudio IDE` (#10999) (@adamrusted) ## SDK Changes ### URL_REGEX -> urlRegex() The exported const `URL_REGEX` has been removed. Please use `urlRegex()` instead: ```javascript import {urlRegex} from 'simple-icons/sdk'; const regex = await urlRegex(); ``` ### .jsonschema.json Now `.jsonschema.json` file is bundled in our package. For more details, please see: #10276.
Issue: closes #9256 Closes #6074
Similarweb rank: 2,302. See https://www.similarweb.com/website/huggingface.co
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
SVG: Taken from https://huggingface.co/brand
Color Taken from major color in logo
#FFD21E