-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor JSONSchema and URL checks #10276
Conversation
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
The previous comment (now hidden) has no sense because in this PR I'm using the same regex for JSONSchema check and in the code. The regex can't be removed. |
Hey @mondeja - are you okay to resolve the conflicts on this ready for next week? We can look to merge in as part of the major release then :) |
As I remember we are planning to move the SDK part to a module. |
Don't worry, I'll resolve the conflicts before the Wednesday regardless of whether we move the SDK to a separate npm package. In that case, the changes proposed by this PR must be included. Feel free to open the PR to separate the SDK meanwhile @LitoMore. If not, I'll open it before the weekend if I have time for it, anyways we can always postpone that change for v13. |
Ok, I will try to create the new repository for SDK. |
As you want but we can release it from this same repository. Probably this approach is better because there are some files in simple-icons/simple-icons that the SDK needs to work. |
Okay, we need to change this repository to workspaces. The folder structure needs some changes. |
This is ready @LitoMore, would you mind to review it? |
…enamed icons (v12.0.0) ## New Icons - Audiobookshelf (#10605) (@21st-centuryman) - Awwwards (#10539) (@stefanobartoletti) - Foundry Virtual Tabletop (#10575) (@adamrusted) - FusionAuth (#10776) (@service-paradis) - Homepage (#10452) (@21st-centuryman) - Hugging Face (#9259) (@PratyushJayachandran) - Kagi (#10976) (@uncenter) - n8n (#10909) (@CodeShakingSheep) - Posit (#10987) (@cwickham) - React Bootstrap (#10921) (@CodeShakingSheep) - Sartorius (#10967) (@CodeShakingSheep) - UiPath (#10773) (@Mvlprem) - unpkg (#10317) (@service-paradis) - Zigbee2MQTT (#10212) (@PeterShaggyNoble) ## Updated Icons - Adidas (#10982) (@jglamp) - FastAPI (#10663) (@uncenter) - RenovateBot (#10996) (@sisp) ## Removed Icons - FITE (#10060) (@PeterShaggyNoble) - Flattr (#10380) (@service-paradis) - Google Bard (#10453) (@PeterShaggyNoble) - Integromat (#10152) (@PeterShaggyNoble) - Niantic (#10979) (@PratyushJayachandran) - Nintendo Network (#10006) (@adamrusted) - Rome (#10113) (@PeterShaggyNoble) - Shotcut (#10043) (@PeterShaggyNoble) - Skynet (#10504) (@kwypchlo) - Twitter (#9748) (@adamrusted) ## Renamed Icons - `Airbrake.io` to `Airbrake` (#10513) (@PeterShaggyNoble) - `Amazon Web Services` to `Amazon Web Services` (#10391) (@readboy8) - `RStudio` to `RStudio IDE` (#10999) (@adamrusted) ## SDK Changes ### URL_REGEX -> urlRegex() The exported const `URL_REGEX` has been removed. Please use `urlRegex()` instead: ```javascript import {urlRegex} from 'simple-icons/sdk'; const regex = await urlRegex(); ``` ### .jsonschema.json Now `.jsonschema.json` file is bundled in our package. For more details, please see: #10276.
const
instead of single value enum for custom license types in JSONSchema.getIconsData*
functions of SDK.