Update TELE 5 #10170
Merged
Update TELE 5 #10170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
update icon/data
26 tasks
adamrusted
approved these changes
Dec 31, 2023
|
According to https://github.com/simple-icons/simple-icons/blob/develop/VERSIONING.md. This should be a breaking change. |
LitoMore
added
the
breaking change
But we're not 'renaming' an icon persay. The slug stays exactly the same, it's just the display name has a space in it. I've had multiple icons in the past where it's changed casing of the title - or added/removed a space and they've not been considered breaking changes. |
LitoMore
added
in discussion
|
I agree. I remember we had this discussion before. But this will be treated as a breaking change in the |
|
Chill - well given there wasn't a release on Sunday, I'll look to get this merged in as part of v11 going out next week. |
adamrusted
removed
the
in discussion
mondeja
added a commit
that referenced
this pull request
Jan 7, 2024
# New Icons - Cooler Master (#10209) - DeepCool (#10204) - Make (#10165) - SideQuest (#10202) - SiYuan (#10187) - Stagetimer (#10104) - Victron Energy (#10198) - Wyze (#10188) # Updated Icons - Affinity Designer (#10176) - Affinity Photo (#10176) - Affinity Publisher (#10176) - Biome (#10203) - Google Chrome (#10116) - INFINITI (#10118) - Opel (#10159) - RTL (#10166) - smart (#10168) - STARZ (#10169) - TELE 5 (#10170) - Wish (#10171) # Removed Icons - Babylon.js (#9980) - Hulu (#10048) - Pepsi (#10086) - Uno (#9973)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10073
Similarweb rank: 180686
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
I can't remember if adding a space to a brand's name constitutes a breaking change; I don't think it does.
Colour is taken from the logo on their website. Possible alternative colour:
#000629, from the website's stylesheet.