Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Biome #10203

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Update Biome #10203

merged 3 commits into from
Jan 5, 2024

Conversation

nhedger
Copy link
Contributor

@nhedger nhedger commented Jan 2, 2024

image

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

This PR updates the logo of Biome to the new one.

Reference: https://github.com/biomejs/resources

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label Jan 2, 2024
@PeterShaggyNoble PeterShaggyNoble added the pending Issues that are pending because of e.g. a scheduled brand update label Jan 5, 2024
@PeterShaggyNoble
Copy link
Member

Thanks for the contribution, @nhedger 👍🏻

Labelling this as pending Issues that are pending because of e.g. a scheduled brand update as they have not yet rolled this new branding out to their website.

To make sure we're comparing like with like in our review, could you let us know which file you based your icon on?

@nhedger
Copy link
Contributor Author

nhedger commented Jan 5, 2024

Thanks @PeterShaggyNoble,

The icon is based on https://github.com/biomejs/resources/blob/main/svg/icon-light-mono.svg

We've started rolling out the new logo on the GitHub org, IDE extensions, Discord, etc.

If you'd prefer for the website redesign to land to update the icon, I understand.

Cheers

PeterShaggyNoble
PeterShaggyNoble approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, @nhedger, I didn't realise you were a member of the Biome team. In that case we can update our icon now on your say-so.

_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble merged commit efc8eb3 into simple-icons:develop Jan 5, 2024
3 checks passed
@github-actions github-actions bot removed the pending Issues that are pending because of e.g. a scheduled brand update label Jan 5, 2024
@nhedger
Copy link
Contributor Author

nhedger commented Jan 5, 2024

My bad, I forgot to mention it!

Thanks for merging!

@github-actions github-actions bot mentioned this pull request Jan 7, 2024
Merged
mondeja added a commit that referenced this pull request Jan 7, 2024
@mondeja
Release 8 new icons and 12 updated icons and 4 removed icons (v11.0.0)
9827973 
# New Icons

- Cooler Master (#10209)
- DeepCool (#10204)
- Make (#10165)
- SideQuest (#10202)
- SiYuan (#10187)
- Stagetimer (#10104)
- Victron Energy (#10198)
- Wyze (#10188)

# Updated Icons

- Affinity Designer (#10176)
- Affinity Photo (#10176)
- Affinity Publisher (#10176)
- Biome (#10203)
- Google Chrome (#10116)
- INFINITI (#10118)
- Opel (#10159)
- RTL (#10166)
- smart (#10168)
- STARZ (#10169)
- TELE 5 (#10170)
- Wish (#10171)

# Removed Icons

- Babylon.js (#9980)
- Hulu (#10048)
- Pepsi (#10086)
- Uno (#9973)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhedger @PeterShaggyNoble