Remove Babylon.js #9980
Merged
Remove Babylon.js #9980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
breaking change
Closed
adamrusted
approved these changes
Jan 2, 2024
mondeja
added a commit
that referenced
this pull request
Jan 7, 2024
# New Icons - Cooler Master (#10209) - DeepCool (#10204) - Make (#10165) - SideQuest (#10202) - SiYuan (#10187) - Stagetimer (#10104) - Victron Energy (#10198) - Wyze (#10188) # Updated Icons - Affinity Designer (#10176) - Affinity Photo (#10176) - Affinity Publisher (#10176) - Biome (#10203) - Google Chrome (#10116) - INFINITI (#10118) - Opel (#10159) - RTL (#10166) - smart (#10168) - STARZ (#10169) - TELE 5 (#10170) - Wish (#10171) # Removed Icons - Babylon.js (#9980) - Hulu (#10048) - Pepsi (#10086) - Uno (#9973)
|
Has this ever mentioned to Babylon.JS? If not, I can send an issue to their branding to see if we can get this sorted. |
|
Don't think so, no. We've recently started cracking down on requiring permission, and BabylonJS was one that we previously hadn't obtained permission for. Happy for you to reach out if you like, see the new guidelines if you're unsure. |
|
Alright I reached out. See here. |
|
Answered in the referenced issue. Thanks for reaching out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: ref: #6317 & #8737
Description
As permission to include a monochrome version of Bablylon.js' icon was not sought prior to #8737 being merged and we have yet to receive a response to our request for permission to do so, we will need to remove Babylon.js from our collection. If permission is granted prior to the release of v11 then this PR can be closed.