-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SiYuan icon #10187
Add SiYuan icon #10187
Conversation
It seems that the JSON Schema verify of Lines 651 to 663 in 6f97719
REF: RFC 5646: Script Subtag |
Correct, the |
@adamrusted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally happy with the icon itself, given how rubbish the source SVG is!
Given you've done a fair bit of work on this though, I'll ask another maintainer to review before we merge!
Merging this in based on Adam's approval above. |
# New Icons - Cooler Master (#10209) - DeepCool (#10204) - Make (#10165) - SideQuest (#10202) - SiYuan (#10187) - Stagetimer (#10104) - Victron Energy (#10198) - Wyze (#10188) # Updated Icons - Affinity Designer (#10176) - Affinity Photo (#10176) - Affinity Publisher (#10176) - Biome (#10203) - Google Chrome (#10116) - INFINITI (#10118) - Opel (#10159) - RTL (#10166) - smart (#10168) - STARZ (#10169) - TELE 5 (#10170) - Wish (#10171) # Removed Icons - Babylon.js (#9980) - Hulu (#10048) - Pepsi (#10086) - Uno (#9973)
GitHub stars: ~13.7k (2023-12-26)
Similarweb rank: ~516k (2023-12-26)
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description