Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autozone #10379

Merged
merged 11 commits into from Feb 23, 2024
Merged

Conversation

adamstgr
Copy link
Contributor

@adamstgr adamstgr commented Jan 30, 2024

autozone

Issue: closes #10271

Similarweb rank: 1628

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Stacked icon reference images from the app store icon and AutoZonePro.

Recreated the stacked icon image using an svg from Autozone.com.

Hex value was determined based on the lettering for the name of the company which is consistent though it differs from the color of slashes that precedes the lettering.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 30, 2024
@mondeja mondeja changed the title Adds Autozone icon, annotations and json changes Add Autozone Feb 2, 2024
@adamrusted
Copy link
Member

Thanks @adamstgr - where did you find the specific SVG you used? The one at source has a much larger shape on the left-hand side.

@adamstgr
Copy link
Contributor Author

adamstgr commented Feb 7, 2024

@adamrusted image here. It was selected based on the discussion around the initial Autozone request.

This case didn't seem to neatly fall into the categories on the Source Guidelines for the contributing doc because it's using the images folder but trying to access autozone.com/images will redirect to autozone.com. Should I change to the change the link to be the one I've included above, directly to the image?

icons/autozone.svg Show resolved Hide resolved
@adamrusted
Copy link
Member

Should I change to the change the link to be the one I've included above, directly to the image?

Nope, the homepage is fine - I wasn't aware that one was buried in the source code!

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing those same differences Adam pointed out, @adamstgr, and I don't know that increasing the precision to 5 is going to fix it, although it's always worth a try. It appears that the stripes in yours have shifted up somewhere along the way - if I manually align them to the same Y coordinate as the ones in the source file then they line up perfectly.

Also, I'd still love if we could find or recreate a vector of the stacked version of the logo; it would suit our needs much better.

@adamstgr
Copy link
Contributor Author

adamstgr commented Feb 8, 2024

@PeterShaggyNoble I'll track down or recreate a vector of the stacked version of the logo

@adamrusted adamrusted removed their request for review February 22, 2024 21:28
@PeterShaggyNoble PeterShaggyNoble added the vector unavailable Issues and Pull Requests where no official SVG is available. label Feb 23, 2024
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @adamstgr 👍🏻 Even making allowances for the poor quality of the app icon, you version is showing more differences than we would normally allow. But, after discussing it with @adamrusted, we're both agreed that as you've used elements from an officially sourced SVG to recreate it that we're OK to run with is as-is in this case.

If anyone feels different strongly enough or we ever find a better version, preferably vector, of it then we can always revisit it.

@PeterShaggyNoble PeterShaggyNoble merged commit 454bb9a into simple-icons:develop Feb 23, 2024
3 checks passed
mondeja added a commit that referenced this pull request Feb 25, 2024
# New Icons

- ALX (#10487) (@Mvlprem)
- AutoZone (#10379) (@adamstgr)
- Bazel (#10477) (@dzintars)
- Ecovacs (#10509) (@ronschaeffer)
- GeoPandas (#10398) (@yhmyhm0910)
- Google Gemini (#10461) (@adamrusted)
- iRobot (#10459) (@ronschaeffer)
- JOUAV (#10469) (@geoyee)
- National Rail (#10505) (@Mvlprem)
- Perplexity (#10482) (@21st-centuryman)
- Twinkly (#10485) (@adamrusted)
- Wondershare Filmora (#10492) (@Mvlprem)

# Updated Icons

- Backendless (#10518) (@adamrusted)
- Clarivate (#10518) (@adamrusted)
- Leanpub (#10518) (@adamrusted)
- Lemmy (#10518) (@adamrusted)
- OpenJDK (#10518) (@adamrusted)
- SWC (#10518) (@adamrusted)
- Zulip (#10518) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon vector unavailable Issues and Pull Requests where no official SVG is available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Autozone
3 participants