Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GeoPandas #10398

Merged
merged 11 commits into from
Feb 22, 2024
Merged

Add GeoPandas #10398

merged 11 commits into from
Feb 22, 2024

Conversation

yhmyhm0910
Copy link
Contributor

@yhmyhm0910 yhmyhm0910 commented Feb 4, 2024

GeoPandas

Issue: closes #10387

Similarweb rank: 413,896

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Hex value is found in its official website
  • Used Inkscape to edit original SVG from here
  • No multiple sources used

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 4, 2024
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some slight differences in the logo, most likely down to precision being too low. Could you re-try with a precision of 4 decimals please? Also, if the SVG source is taken from the homepage, you don't need to link to the exact file. Just using https://geopandas.org would be sufficient.

@yhmyhm0910
Copy link
Contributor Author

Is the precision ok? I edited the SVG with Inkscape and changed its size to 24px*24px, fit to the document.

@PeterShaggyNoble PeterShaggyNoble changed the title Add Geopandas Icon Add GeoPandas Feb 12, 2024
@PeterShaggyNoble
Copy link
Member

@yhmyhm0910, did you try a precision of 4 first? And what did you use for the optimisation? There are quite a few unnecessary spaces in the path.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/geopandas.svg Outdated Show resolved Hide resolved
@yhmyhm0910
Copy link
Contributor Author

Optimize the logo using SVGOMG Online Tool with a precision of 4

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a perfect match, thanks for this @yhmyhm0910! 🎉
Looking forward to more contributions from you! 👀

@adamrusted adamrusted merged commit 2f4f984 into simple-icons:develop Feb 22, 2024
4 checks passed
mondeja added a commit that referenced this pull request Feb 25, 2024
# New Icons

- ALX (#10487) (@Mvlprem)
- AutoZone (#10379) (@adamstgr)
- Bazel (#10477) (@dzintars)
- Ecovacs (#10509) (@ronschaeffer)
- GeoPandas (#10398) (@yhmyhm0910)
- Google Gemini (#10461) (@adamrusted)
- iRobot (#10459) (@ronschaeffer)
- JOUAV (#10469) (@geoyee)
- National Rail (#10505) (@Mvlprem)
- Perplexity (#10482) (@21st-centuryman)
- Twinkly (#10485) (@adamrusted)
- Wondershare Filmora (#10492) (@Mvlprem)

# Updated Icons

- Backendless (#10518) (@adamrusted)
- Clarivate (#10518) (@adamrusted)
- Leanpub (#10518) (@adamrusted)
- Lemmy (#10518) (@adamrusted)
- OpenJDK (#10518) (@adamrusted)
- SWC (#10518) (@adamrusted)
- Zulip (#10518) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: GeoPandas
3 participants