-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bazel icon #10477
Add Bazel icon #10477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a version of that SVG available on the homepage, and when comparing to that version, I'm seeing the below differences. Would you mind taking another look wit the updated source, @dzintars?
31a7b84
to
84445cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the speedy update @dzintars!
Unfortunately I'm still seeing similar - but different - differences!
My path (one in green above) is included below. Feel free to use that if you'd prefer. I've already optimised it to 4 decimals - so should be a drop-in for your path.
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>Bazel</title><path d="m11.7473 23.8198-5.4987-5.4987v-5.5349l5.4987 5.4986v5.535zm-.1036-17.6412-.0001-.0001.1768-.1768L5.9986.1799.1768 6.0018l.0001.0001 5.8217 5.8271 5.6451-5.6504zM0 6.5323v5.5347l5.7486 5.7539v-5.5347l-.1035-.1035.0001-.0001L0 6.5323zm17.6478 5.6504-5.6505-5.6505-5.6452 5.6504 5.6452 5.6453 5.6505-5.6452zm.1036 5.8885v-5.2853l-5.5042 5.4991v5.5351l5.5042-5.4991v-.2498zM24 6.5323l-5.6451 5.6503.0001.0001-.1036.1035v5.5346L24 12.067V6.5323zm-.1769-.5304.0001-.0001L18.0014.18l-5.8273 5.822 5.8273 5.8272 5.8217-5.8273z"/></svg>
Due to challenges within monochromatic icon requirements I added gaps/cutouts between the elements. Size of the gap was "eyeballed" so that it looks kind of fine for small 16px icons on non-retina screens. (10px gap on 512px scale icon) I didn't found any styleguide, so color was picked from there https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html Outlined version was discarded as it looks terrible on a small icons an overall community favored filled version. Keeping mathematically correct element sizes and corner positions are kind of challenging but current solution is close enough. I even went so far that I modeled icon in 3D software to get accurate projection, but... original icon does not count in real isometry. So I discarded true 3D version of SVG as well. closes: simple-icons#8166
@adamrusted May I ask, what tool/s do you use to work with these SVG's so swiftly? |
I use a mix. Typically I'm in Affinity Designer, but if that doesn't play ball for whatever reason I swap to Adobe Illustrator. Paid tools and a LOT of spare time during the pandemic gets you pretty swift at these reviews! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dzintars, I see similar results as @adamrusted noted. Seems like a scaling issue. Please increase the precision of the software you are using and try once more.
It anymore doesn't make any sense to me and I'm keen to abandon all this thing. Nor I'm a designer, nor do I need this icon. I read Contribution guidelines several time and I didn't saw a single requirement/guidelines about the cutouts. First I spent tremendous amount for this little issue to draw those cutouts by hand in the Figma and tried to align to full pixels. Then I listened @adamrusted advice, installed Inkscape and made 0.25pt stroke for every element and cut it out. Lastly I just copied the path @adamrusted gave me above. So... it seems that there is no consensus about the requirements, nor they are documented anywhere. I can't just waste my time by fixing "it doesn't look right on my screen/software" issue. Edit: My steps: https://gist.github.com/dzintars/6443e72e4b0ae058f5fb8a8fc6b3f9c6 |
Thanks for posting your steps, @dzintars! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience on this one, @dzintars, your frustration is understandable given the work you've put into this and that this has been dragging on for over a year now - we've all been there. The reason we don't document our requirements for cut-outs is that 0.5dp is merely our baseline and we will, on occasion, use 1dp or 0.25dp if it works better for a given icon. By not documenting the 0.5dp baseline, we avoid the reverse of the frustration you're feeling if we have to ask someone to change it.
Anyway, I've identified the source of the differences @PratyushJayachandran was seeing: The cut-outs are reducing the height of the icon by chopping off the very bottom corner, so it then has to be realigned vertically on the canvas. When you compare it back to the original also perfectly centred on the canvas, you'll see those differences. But if you adjust the Y coordinate of yours to match the source then everything lines up perfectly.
So this one is good to go 🙂 Thanks again for your ongoing efforts on it 👍🏻
# New Icons - ALX (#10487) (@Mvlprem) - AutoZone (#10379) (@adamstgr) - Bazel (#10477) (@dzintars) - Ecovacs (#10509) (@ronschaeffer) - GeoPandas (#10398) (@yhmyhm0910) - Google Gemini (#10461) (@adamrusted) - iRobot (#10459) (@ronschaeffer) - JOUAV (#10469) (@geoyee) - National Rail (#10505) (@Mvlprem) - Perplexity (#10482) (@21st-centuryman) - Twinkly (#10485) (@adamrusted) - Wondershare Filmora (#10492) (@Mvlprem) # Updated Icons - Backendless (#10518) (@adamrusted) - Clarivate (#10518) (@adamrusted) - Leanpub (#10518) (@adamrusted) - Lemmy (#10518) (@adamrusted) - OpenJDK (#10518) (@adamrusted) - SWC (#10518) (@adamrusted) - Zulip (#10518) (@adamrusted)
Issue: closes #8166
Similarweb rank: 375340
GitHub stars: 22k
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Original icon source: https://blog.bazel.build/images/bazel-icon.svg
New logo announcement: https://blog.bazel.build/2017/07/05/new-logo-and-homepage.html
Cutouts are made in a such way that they look fine on 16px icon on a non-retina screen.
General consensus went for a filled variant which looks better than outline variant.