Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecovacs #10509

Merged
merged 24 commits into from Feb 23, 2024
Merged

Add Ecovacs #10509

merged 24 commits into from Feb 23, 2024

Conversation

ronschaeffer
Copy link
Contributor

@ronschaeffer ronschaeffer commented Feb 22, 2024

image

Issue: closes #

Similarweb rank: 63,922

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Vector created from rasterized image https://mma.prnewswire.com/media/1232042/ECOVACS_Logo.jpg distributed as part of an official press release.

Color 19374F picked from the color of the E here https://mma.prnewswire.com/media/1232042/ECOVACS_Logo.jpg, which is also the color of the remainder of the wordmark https://mma.prnewswire.com/media/2216491/Ecovacs_Logo_Logo.jpg.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Feb 22, 2024
@Mvlprem
Copy link
Member

Mvlprem commented Feb 22, 2024

Thanks for the contribution, @ronschaeffer You can find the vector version in their product manual DEEBOT OZMO T8

@ronschaeffer
Copy link
Contributor Author

ronschaeffer commented Feb 22, 2024

Thanks for the contribution, @ronschaeffer You can find the vector version in their product manual DEEBOT OZMO T8

Thanks. I didn't use user manuals as a source, because the logo is incorrectly applied in all user manuals that I checked--about half a dozen of them.

The lower curve is clipped at the bottom in the user manuals:

image

Also, the logo is also stretched vertically when compared to official PNGs on the website and in press releases. The PNGs I've checked are consistent with each other. The user manual version is shown in yellow below overlayed on the official PNG.

image

@ronschaeffer
Copy link
Contributor Author

The user manual vector can presumably be replied upon for the color reference, so I've updated simple-icons.json with the color 1E384B.

@adamrusted adamrusted added the vector unavailable Issues and Pull Requests where no official SVG is available. label Feb 22, 2024
@Mvlprem
Copy link
Member

Mvlprem commented Feb 23, 2024

@ronschaeffer I believe that the image you used to make the svg is from this news website PR Newswire if that's the case i don't think we take that as an official source, as far as i know the image must be from the website, or from a document found on website, git hub project or Wikipedia.

In that case i suggest to use the vector in one of their product manual, now i know it's not perfect as you pointed out, but as long as they are using it in their official document we are good with it. Just to be sure I'll ask another maintainer to take a look and let's see what he has to say about this if they are good with your decision then you can go ahead.

@adamrusted, @PeterShaggyNoble What are your thoughts on this ?

@ronschaeffer
Copy link
Contributor Author

ronschaeffer commented Feb 23, 2024

You guys drive a hard bargain. ;-) Good to have the quality control though. Thanks.

With more searching, I found a new user manual that applies the logo correctly at https://site-static.ecovacs.com/upload/us/file/support/2023/11/01/023149_6306-X2OMNIInstructionManual.pdf

My new .SVG commit is based on this.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for this @ronschaeffer!
Always pays for us to be detail oriented! 🔎

@adamrusted adamrusted merged commit 06cfdb2 into simple-icons:develop Feb 23, 2024
4 checks passed
@adamrusted adamrusted removed the vector unavailable Issues and Pull Requests where no official SVG is available. label Feb 23, 2024
mondeja added a commit that referenced this pull request Feb 25, 2024
# New Icons

- ALX (#10487) (@Mvlprem)
- AutoZone (#10379) (@adamstgr)
- Bazel (#10477) (@dzintars)
- Ecovacs (#10509) (@ronschaeffer)
- GeoPandas (#10398) (@yhmyhm0910)
- Google Gemini (#10461) (@adamrusted)
- iRobot (#10459) (@ronschaeffer)
- JOUAV (#10469) (@geoyee)
- National Rail (#10505) (@Mvlprem)
- Perplexity (#10482) (@21st-centuryman)
- Twinkly (#10485) (@adamrusted)
- Wondershare Filmora (#10492) (@Mvlprem)

# Updated Icons

- Backendless (#10518) (@adamrusted)
- Clarivate (#10518) (@adamrusted)
- Leanpub (#10518) (@adamrusted)
- Lemmy (#10518) (@adamrusted)
- OpenJDK (#10518) (@adamrusted)
- SWC (#10518) (@adamrusted)
- Zulip (#10518) (@adamrusted)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants