Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openmediavault icon #10568

Merged
merged 6 commits into from
May 18, 2024
Merged

Add openmediavault icon #10568

merged 6 commits into from
May 18, 2024

Conversation

uncenter
Copy link
Member

@uncenter uncenter commented Mar 4, 2024 •
edited

openmediavault

Issue: closes #7186.

Similarweb rank: https://www.similarweb.com/website/openmediavault.org/#overview.

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 4, 2024
@adamrusted
Copy link
Member

Hey @uncenter - where did you source this icon from? I can only see a PNG on the source page listed...

@uncenter
Copy link
Member Author

uncenter commented Mar 4, 2024

Hey @uncenter - where did you source this icon from? I can only see a PNG on the source page listed...

There's an SVG file right above the png file that I grabbed.

Screenshot 2024-03-04 at 06 27 27 (Arc)

https://github.com/openmediavault/openmediavault/blob/master/deb/openmediavault/workbench/src/favicon.svg

adamrusted
adamrusted requested changes Mar 5, 2024
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON looks spot on, just a query around the SVG.

icons/openmediavault.svg Outdated Show resolved Hide resolved
@uncenter uncenter changed the title Add openmediavault Add openmediavault icon Mar 5, 2024
@uncenter uncenter requested a review from adamrusted March 5, 2024 15:06
PeterShaggyNoble
PeterShaggyNoble previously requested changes Mar 15, 2024
View reviewed changes
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing some small differences in all 4 outer corners, as a result of Inkscape being crap at converting strokes to paths. Could you see if you could tweak those manually to line up better? Or you may find it easier to redraw the shape from scrtach.

_data/simple-icons.json Outdated Show resolved Hide resolved
uncenter and others added 2 commits March 15, 2024 10:34
@uncenter @PeterShaggyNoble
Update _data/simple-icons.json
677f54a 
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@uncenter
Improve corners
b1198d3
@uncenter
Copy link
Member Author

I'm seeing some small differences in all 4 outer corners, as a result of Inkscape being crap at converting strokes to paths. Could you see if you could tweak those manually to line up better? Or you may find it easier to redraw the shape from scrtach.

Thanks for pointing that out! I just committed a refined version where the corners match up.

adamrusted
adamrusted approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @uncenter 🎉

@adamrusted adamrusted merged commit 4b550fc into simple-icons:develop May 18, 2024
3 checks passed
@uncenter uncenter deleted the feat/add-openmediavault branch May 18, 2024 15:14
@simple-icons simple-icons bot mentioned this pull request May 19, 2024
Merged
simple-icons bot added a commit that referenced this pull request May 19, 2024
@simple-icons
Release 22 new icons and 5 updated icons (v11.15.0)
1b5de10 
# New Icons

- Buhl (#10919) (@CodeShakingSheep)
- Cal.com (#10908) (@H0onnn)
- Calibre-Web (#10950) (@CodeShakingSheep)
- Dota 2 (#10574) (@ryanmurphyNSCC)
- Fizz (#10873) (@service-paradis)
- FreeCAD (#8879) (@PratyushJayachandran)
- freelancermap (#10946) (@CodeShakingSheep)
- Homarr (#10964) (@CodeShakingSheep)
- Infomaniak (#10930) (@CodeShakingSheep)
- Lemon Squeezy (#10900) (@CodeShakingSheep)
- LimeSurvey (#10901) (@CodeShakingSheep)
- listmonk (#10916) (@CodeShakingSheep)
- MainWP (#10917) (@CodeShakingSheep)
- OpenJS Foundation (#10854) (@10xLaCroixDrinker)
- openmediavault (#10568) (@uncenter)
- Optimism (#10918) (@CodeShakingSheep)
- Quarto (#10960) (@cwickham)
- Quizlet (#10721) (@EricRisher)
- RubyMine (#10707) (@davidlj95)
- Tailscale (#10744) (@mani-sh-reddy)
- Traccar (#10910) (@CodeShakingSheep)
- Twinmotion (#10832) (@uncenter)

# Updated Icons

- Abbvie (#10953) (@jglamp)
- freedesktop.org (#10911) (@uncenter)
- Immich (#10738) (@mani-sh-reddy)
- Lamborghini (#10835) (@PratyushJayachandran)
- Tencent QQ (#10932) (@LitoMore)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble left review comments

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: openmediavault
3 participants
@uncenter @adamrusted @PeterShaggyNoble