Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dota 2 icon #10574

Merged
merged 5 commits into from
May 18, 2024
Merged

Add Dota 2 icon #10574

merged 5 commits into from
May 18, 2024

Conversation

ryanmurphyNSCC
Copy link
Contributor

Issue: closes #10567

Similarweb rank: 36,750

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The hex value is the main colour of the logo
I did not manually vectorize the logo, I got the SVG of the logo and isolated it using BoxySVG and then optimized in SVGO.
Only used one source, the one listed in the json data file.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 5, 2024
@adamrusted adamrusted changed the title Add Dota 2 Add Dota 2 icon Mar 5, 2024
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ryanmurphyNSCC for your contribution. I left a few comments if you can take a look!

icons/dota2.svg Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Paradis <service.paradis@gmail.com>
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ryanmurphyNSCC

@adamrusted adamrusted merged commit 4fc5c78 into simple-icons:develop May 18, 2024
3 checks passed
simple-icons bot added a commit that referenced this pull request May 19, 2024
# New Icons

- Buhl (#10919) (@CodeShakingSheep)
- Cal.com (#10908) (@H0onnn)
- Calibre-Web (#10950) (@CodeShakingSheep)
- Dota 2 (#10574) (@ryanmurphyNSCC)
- Fizz (#10873) (@service-paradis)
- FreeCAD (#8879) (@PratyushJayachandran)
- freelancermap (#10946) (@CodeShakingSheep)
- Homarr (#10964) (@CodeShakingSheep)
- Infomaniak (#10930) (@CodeShakingSheep)
- Lemon Squeezy (#10900) (@CodeShakingSheep)
- LimeSurvey (#10901) (@CodeShakingSheep)
- listmonk (#10916) (@CodeShakingSheep)
- MainWP (#10917) (@CodeShakingSheep)
- OpenJS Foundation (#10854) (@10xLaCroixDrinker)
- openmediavault (#10568) (@uncenter)
- Optimism (#10918) (@CodeShakingSheep)
- Quarto (#10960) (@cwickham)
- Quizlet (#10721) (@EricRisher)
- RubyMine (#10707) (@davidlj95)
- Tailscale (#10744) (@mani-sh-reddy)
- Traccar (#10910) (@CodeShakingSheep)
- Twinmotion (#10832) (@uncenter)

# Updated Icons

- Abbvie (#10953) (@jglamp)
- freedesktop.org (#10911) (@uncenter)
- Immich (#10738) (@mani-sh-reddy)
- Lamborghini (#10835) (@PratyushJayachandran)
- Tencent QQ (#10932) (@LitoMore)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Dota 2
4 participants