Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FreeCAD icon #8879

Merged
merged 7 commits into from
May 18, 2024
Merged

Add FreeCAD icon #8879

merged 7 commits into from
May 18, 2024

Conversation

PratyushJayachandran
Copy link
Member

freecad

Issue: closes #7295

Similarweb rank: 60,929. See https://www.similarweb.com/website/freecad.org

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from website header https://www.freecad.org
Color: #729FCF Taken from one of the colors in the logo.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 25, 2023
LitoMore
LitoMore requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://www.freecad.org/svg/icon-freecad.svg.

There should be a gap between F and the gear. And it loses too many details from the original design.

Better to ask their team for advice.

@PratyushJayachandran
Copy link
Member Author

See https://www.freecad.org/svg/icon-freecad.svg.

There should be a gap between F and the gear. And it loses too many details from the original design.

Better to ask their team for advice.

Yes. I was split on this one. I tried with a gap between F and gear but the way the teeth are positioned, it makes it look weird. I'll try once more with a different approach or we can ask them.

@PratyushJayachandran
Copy link
Member Author

There should be a gap between F and the gear. And it loses too many details from the original design.

freecad
I added a gap.
@LitoMore please review

@adamrusted adamrusted requested a review from LitoMore July 19, 2023 17:28
LitoMore
LitoMore requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@PratyushJayachandran Please don't change the style of the corner.

@PratyushJayachandran
Copy link
Member Author

image

@PratyushJayachandran Please don't change the style of the corner.

I didn't understand what you meant by corner.

Just to note, the wireframe for original logo in this comparison image doesn't show the stroke that is around F and the gear symbol. I didn't change the corner style for those strokes but I'll re-check.

@LitoMore
Copy link
Member

image

This is corner.

image

Those corners in your design are angled.

image

@PratyushJayachandran
Copy link
Member Author

image

This is corner.
image

Those corners in your design are angled.
image

Okay my assumption was close. I'll recheck the source and correct. Thank you for the review and detailed explanation.

@LitoMore LitoMore removed their assignment Jul 21, 2023
@PratyushJayachandran
Copy link
Member Author

image

@PratyushJayachandran Please don't change the style of the corner.

@LitoMore the corner style was take as is from the logo. It looks different in wire frame mode as it is a stroke. Please look at the following image
image

@PeterShaggyNoble
Copy link
Member

What are people's thoughts on this approach? Or should we keep both the "F" and the cog solid and just have a cut-out where they overlap?

@PeterShaggyNoble
Copy link
Member

Don't forget about this one, @PratyushJayachandran; just need to fix up the corners and it should be good to go.

@PratyushJayachandran
Copy link
Member Author

Don't forget about this one, @PratyushJayachandran; just need to fix up the corners and it should be good to go.

My application is beveling the joints for some reason instead of mitering it like it looks in reality, no matter what I select in the settings. Can you extract the logo mark and attach it here. Maybe saving on a different application might solve the issue. Now I understand why @LitoMore was seeing a different style of corner 😐

@PeterShaggyNoble
Copy link
Member

This any use, @PratyushJayachandran?

@PratyushJayachandran
Copy link
Member Author

This any use, @PratyushJayachandran?

image
SethMeyersStressedGIF

The issue is that I am not able to miter the corners and outlining the strokes results in beveled shape. How do I fix this now 😞

@PeterShaggyNoble
Copy link
Member

And I thought Inkscape was a jerk with strokes! 😆 What software are you using?

I'll have a go at doing the icon myself shortly.

@PeterShaggyNoble
Copy link
Member

What do you reckon to this, @PratyushJayachandran? I took the liberty of redrawing the inner circle of the cog while I was at it.

M -218.45535,3.0090742V 73.544161h 16.45818V 45.330126h 14.10702V 28.871939h -14.10702v -9.404678h 23.5117V 3.0090742Zm 45.70889,18.8105048 -4.81599,0.252556a 1.1756577,1.1756062 0 0 0 -1.06767,0.866726l -2.06072,7.570939 -2.1009,1.004484 -3.62778,-1.584214v 16.869591h -13.21385l 0.26979,4.672286a 1.1756577,1.1756062 0 0 0 0.86102,1.067623l 7.57127,2.054887 1.01027,2.100807 -3.16283,7.163406a 1.1756577,1.1756062 0 0 0 0.28701,1.348878l 3.59908,3.23731a 1.1756577,1.1756062 0 0 0 1.3719,0.149237l 6.79635,-3.903138 2.20996,0.786368 2.84138,7.312643a 1.1756577,1.1756062 0 0 0 1.15951,0.751928l 4.85044,-0.269776a 1.1756577,1.1756062 0 0 0 1.07341,-0.872466l 2.03201,-7.576679 2.09516,-1.004484 7.18668,3.174169a 1.1756577,1.1756062 0 0 0 1.35468,-0.292735l 3.23745,-3.598922a 1.1756577,1.1756062 0 0 0 0.14351,-1.371839l -3.90331,-6.801792 0.76918,-2.209865 7.30722,-2.841254a 1.1756577,1.1756062 0 0 0 0.75196,-1.153722l -0.24682,-4.844483a 1.1756577,1.1756062 0 0 0 -0.86677,-1.073363l -7.57701,-2.031928 -1.01027,-2.100806 3.15135,-7.197846a 1.1756577,1.1756062 0 0 0 -0.29275,-1.348879l -3.59908,-3.237308a 1.1756577,1.1756062 0 0 0 -1.3719,-0.143498l -6.80209,3.897399 -2.187,-0.757668 -2.86434,-7.318385a 1.1756577,1.1756062 0 0 0 -1.15951,-0.746187zm 6.60757,25.866124a 7.6398315,7.6427703 0 0 1 -7.63983,7.642771 7.6398315,7.6427703 0 0 1 -7.63983,-7.642771 7.6398315,7.6427703 0 0 1 7.63983,-7.64277 7.6398315,7.6427703 0 0 1 7.63983,7.64277z

@PratyushJayachandran
Copy link
Member Author

What do you reckon to this, @PratyushJayachandran? I took the liberty of redrawing the inner circle of the cog while I was at it.

M -218.45535,3.0090742V 73.544161h 16.45818V 45.330126h 14.10702V 28.871939h -14.10702v -9.404678h 23.5117V 3.0090742Zm 45.70889,18.8105048 -4.81599,0.252556a 1.1756577,1.1756062 0 0 0 -1.06767,0.866726l -2.06072,7.570939 -2.1009,1.004484 -3.62778,-1.584214v 16.869591h -13.21385l 0.26979,4.672286a 1.1756577,1.1756062 0 0 0 0.86102,1.067623l 7.57127,2.054887 1.01027,2.100807 -3.16283,7.163406a 1.1756577,1.1756062 0 0 0 0.28701,1.348878l 3.59908,3.23731a 1.1756577,1.1756062 0 0 0 1.3719,0.149237l 6.79635,-3.903138 2.20996,0.786368 2.84138,7.312643a 1.1756577,1.1756062 0 0 0 1.15951,0.751928l 4.85044,-0.269776a 1.1756577,1.1756062 0 0 0 1.07341,-0.872466l 2.03201,-7.576679 2.09516,-1.004484 7.18668,3.174169a 1.1756577,1.1756062 0 0 0 1.35468,-0.292735l 3.23745,-3.598922a 1.1756577,1.1756062 0 0 0 0.14351,-1.371839l -3.90331,-6.801792 0.76918,-2.209865 7.30722,-2.841254a 1.1756577,1.1756062 0 0 0 0.75196,-1.153722l -0.24682,-4.844483a 1.1756577,1.1756062 0 0 0 -0.86677,-1.073363l -7.57701,-2.031928 -1.01027,-2.100806 3.15135,-7.197846a 1.1756577,1.1756062 0 0 0 -0.29275,-1.348879l -3.59908,-3.237308a 1.1756577,1.1756062 0 0 0 -1.3719,-0.143498l -6.80209,3.897399 -2.187,-0.757668 -2.86434,-7.318385a 1.1756577,1.1756062 0 0 0 -1.15951,-0.746187zm 6.60757,25.866124a 7.6398315,7.6427703 0 0 1 -7.63983,7.642771 7.6398315,7.6427703 0 0 1 -7.63983,-7.642771 7.6398315,7.6427703 0 0 1 7.63983,-7.64277 7.6398315,7.6427703 0 0 1 7.63983,7.64277z

Well this looks like the possible contributions itself 😨
image

@PeterShaggyNoble
Copy link
Member

Feel free to run with it in that case 🙂

@PeterShaggyNoble PeterShaggyNoble self-assigned this Mar 14, 2024
@service-paradis
Copy link
Member

Not sure why, but the inner circle looks like this in Inkscape on my side 🤔
image

Might need someone else to review this one...

@LitoMore
Copy link
Member

@service-paradis I just checked this icon. It looks good on other SVG editors and browsers.

@uncenter
Copy link
Member

Not sure why, but the inner circle looks like this in Inkscape on my side 🤔 image

Might need someone else to review this one...

Huh I'm also seeing that in Inkscape:

Screenshot 2024-04-22 at 08 39 50 (Inkscape)

Though it looks fine on GitHub:

image

@adamrusted
Copy link
Member

@LitoMore - were you happy with this? If so, can you merge it down please?

@LitoMore LitoMore merged commit e86215f into simple-icons:develop May 18, 2024
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Add-Freecad-#7295 branch May 18, 2024 18:36
@simple-icons simple-icons bot mentioned this pull request May 19, 2024
Merged
simple-icons bot added a commit that referenced this pull request May 19, 2024
@simple-icons
Release 22 new icons and 5 updated icons (v11.15.0)
1b5de10 
# New Icons

- Buhl (#10919) (@CodeShakingSheep)
- Cal.com (#10908) (@H0onnn)
- Calibre-Web (#10950) (@CodeShakingSheep)
- Dota 2 (#10574) (@ryanmurphyNSCC)
- Fizz (#10873) (@service-paradis)
- FreeCAD (#8879) (@PratyushJayachandran)
- freelancermap (#10946) (@CodeShakingSheep)
- Homarr (#10964) (@CodeShakingSheep)
- Infomaniak (#10930) (@CodeShakingSheep)
- Lemon Squeezy (#10900) (@CodeShakingSheep)
- LimeSurvey (#10901) (@CodeShakingSheep)
- listmonk (#10916) (@CodeShakingSheep)
- MainWP (#10917) (@CodeShakingSheep)
- OpenJS Foundation (#10854) (@10xLaCroixDrinker)
- openmediavault (#10568) (@uncenter)
- Optimism (#10918) (@CodeShakingSheep)
- Quarto (#10960) (@cwickham)
- Quizlet (#10721) (@EricRisher)
- RubyMine (#10707) (@davidlj95)
- Tailscale (#10744) (@mani-sh-reddy)
- Traccar (#10910) (@CodeShakingSheep)
- Twinmotion (#10832) (@uncenter)

# Updated Icons

- Abbvie (#10953) (@jglamp)
- freedesktop.org (#10911) (@uncenter)
- Immich (#10738) (@mani-sh-reddy)
- Lamborghini (#10835) (@PratyushJayachandran)
- Tencent QQ (#10932) (@LitoMore)
@mondeja mondeja mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

@service-paradis service-paradis Awaiting requested review from service-paradis

Assignees

@PeterShaggyNoble PeterShaggyNoble

Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: FreeCAD
6 participants
@PratyushJayachandran @LitoMore @PeterShaggyNoble @service-paradis @uncenter @adamrusted