Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Celery icon (#1332) #2110

Merged
merged 4 commits into from Dec 28, 2019
Merged

Add Celery icon (#1332) #2110

merged 4 commits into from Dec 28, 2019

Conversation

phatbhoy67
Copy link
Contributor

@phatbhoy67 phatbhoy67 commented Dec 9, 2019 •
edited

Issue: #1332

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Manual vector interpretation of icon from official project banner .png available from GitHub repo.

Hex value #ddf4a3 is picked from the "C" in official .png the lighter of the three greens used in the logo and the closest to the colour of celery IRL.

Built on GitPod, working as expected.

Manual vector of official .png logo.

Hex value #37814a used on website

Possible alternatives: Logo is green gradient, picked light and dark points #c4e490 #618f3a, #93BA65 is calculated midpoint.

Hex value chosen #37814a.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Dec 9, 2019
runxel
runxel approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your vector stylizing you've done here!
Approving the PR, but I leave it for someone else to merge it in.

@PeterShaggyNoble
Copy link
Member

I missed the original conversation from #1332 but, as it's what they use in their website, I think we should use the boxed C. Should we reach out to @celery for clarification & confirmation?

@birjj
Copy link
Contributor

birjj commented Dec 20, 2019

I agree, the boxed C seems like the most relevant logo in this case.

@phatbhoy67
Copy link
Contributor Author

I think we tried reaching out to @celery previously. The GitHub repo for the project and the project itself use the newer updated logo version. One of the most active maintainers over there is @auvipy maybe he can swing by and give us his opinion and have a look at #1332 ? 😃

@auvipy
Copy link

auvipy commented Dec 21, 2019

I woulddvote for the green one

@runxel
Copy link
Member

runxel commented Dec 22, 2019

I woulddvote for the green one

Hey @auvipy! Thanks for dropping in.
Could you elaborate? "The green one" is kidna under-descriptive (since both are green...)

To be specific: Would you rather like the stylized celery from the github repo or the boxed C from the website as a logo?
Thanks again! ✨

@auvipy
Copy link

auvipy commented Dec 23, 2019

this one https://www.facebook.com/celeryproject/photos/a.1261662700512051/1261675943844060/?type=1&theater

@runxel
Copy link
Member

runxel commented Dec 28, 2019

Since there are no complaints I gladly merge this one in.
Thanks to everybody for contributing! 🌮

@runxel runxel merged commit f8bf03c into simple-icons:develop Dec 28, 2019
@phatbhoy67 phatbhoy67 deleted the celery branch December 28, 2019 18:14
@phatbhoy67 phatbhoy67 mentioned this pull request Dec 28, 2019
Closed
@ericcornelissen ericcornelissen mentioned this pull request Jan 7, 2020
Merged
ericcornelissen added a commit that referenced this pull request Jan 7, 2020
@ericcornelissen
Reease 46 new icons and 4 updated icons (v2.2.0)
9e8a7f9 
# New icons

- GNU Bash (#2185)
- Z-Wave (#2212)
- Convertio (#2213)
- Material UI (#2211)
- Datadog (#2231)
- Audiomack (#2230)
- New York Times (#2224)
- EA (#2237)
- Square Enix (#2236)
- Authy (#2233)
- Activision (#2235)
- ActiGraph (#2234)
- Celery (#2110)
- Photocrowd (#2193)
- WebAssembly (#2244)
- Alipay (#2241)
- ZDF (#2199)
- NDR (#2200)
- Sat.1 (#2203)
- TELE5 (#2206)
- Battle.net (#2215)
- Phonegap (#2247)
- GNU Emacs (#2248)
- Corona Engine (#2245)
- Asciinema (#2218)
- RTLZWEI (#2202)
- figshare (#2220)
- Tomorrowland (#2217)
- iFood (#2209)
- Litecoin (#2210)
- Freelancer (#2254)
- Fandom (#2263)
- Unicode (#2257)
- Pexels (#2261)
- Airtable (#2274)
- XMPP (#2085, #2275)
- Red Hat Open Shift (#2277)
- FITE (#2262)
- Qi (#2255)
- Sencha (#2246)
- Neovim (#2251)
- Qualtrics (#2285)
- VMware (#2265)

# Updated icons

- JSFiddle (#2214)
- Campaign Monitor (#2259)
- Helm (#2273)
- Accusoft (#2291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runxel runxel runxel approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@phatbhoy67 @PeterShaggyNoble @birjj @auvipy @runxel @ericcornelissen