Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pexels #2261

Merged
merged 4 commits into from Jan 5, 2020
Merged

Add Pexels #2261

merged 4 commits into from Jan 5, 2020

Conversation

PeterShaggyNoble
Copy link
Member

Pexels

Issue: Closes #2156

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon & colour from logo in website header. Possible alternative, based on this SVG:

Pexels

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Jan 2, 2020
Copy link
Contributor

@foo-dogsquared foo-dogsquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen no problem with this PR so I approve both versions.
Though, we just have to agree on what version to push through the repo.

I'm leaning more on the first version since I see the logo more with the bounding box (like this recent event page for example).

What do the other maintainers think (@simple-icons/maintainers).

@foo-dogsquared foo-dogsquared added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 3, 2020
@PeterShaggyNoble
Copy link
Member Author

I also haven't seen them using the unboxed version anywhere so I'd say it's safe to disregard it. Even moreso because I've since noticed that it was generated by Potrace and, the more icons I see that are made with it, the more I'm becoming of the opinion that we shouldn't accept them as an official source.

It seems to me like there's something out there that's automatically running raster favicon files through Potrace and adding the link tag to the HTML of sites without anyone first reviewing them. While some of them turn out fine, most seem to be inconsistent with the branding or of very low quality or both.

@ericcornelissen
Copy link
Contributor

It seems to me that indeed the boxed version is the way to go 👍

While some of them turn out fine, most seem to be inconsistent with the branding or of very low quality or both.

It is probably okay that they're low quality because they're always displayed at a small size (namely as a pinned tab in the Safari browser, guessing from the file name). To be fair to Potrace, the standard raster-to-vector algorithms in Illustrator etc. have the same issue. I do agree that we should not use these SVGs as an official sources as the quality is usually too low.

@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 5, 2020
@ericcornelissen ericcornelissen merged commit 61255c5 into simple-icons:develop Jan 5, 2020
@PeterShaggyNoble PeterShaggyNoble deleted the pexels branch January 5, 2020 15:29
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jan 7, 2020
3 tasks
ericcornelissen added a commit that referenced this pull request Jan 7, 2020
# New icons

- GNU Bash (#2185)
- Z-Wave (#2212)
- Convertio (#2213)
- Material UI (#2211)
- Datadog (#2231)
- Audiomack (#2230)
- New York Times (#2224)
- EA (#2237)
- Square Enix (#2236)
- Authy (#2233)
- Activision (#2235)
- ActiGraph (#2234)
- Celery (#2110)
- Photocrowd (#2193)
- WebAssembly (#2244)
- Alipay (#2241)
- ZDF (#2199)
- NDR (#2200)
- Sat.1 (#2203)
- TELE5 (#2206)
- Battle.net (#2215)
- Phonegap (#2247)
- GNU Emacs (#2248)
- Corona Engine (#2245)
- Asciinema (#2218)
- RTLZWEI (#2202)
- figshare (#2220)
- Tomorrowland (#2217)
- iFood (#2209)
- Litecoin (#2210)
- Freelancer (#2254)
- Fandom (#2263)
- Unicode (#2257)
- Pexels (#2261)
- Airtable (#2274)
- XMPP (#2085, #2275)
- Red Hat Open Shift (#2277)
- FITE (#2262)
- Qi (#2255)
- Sencha (#2246)
- Neovim (#2251)
- Qualtrics (#2285)
- VMware (#2265)

# Updated icons

- JSFiddle (#2214)
- Campaign Monitor (#2259)
- Helm (#2273)
- Accusoft (#2291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pexels (copyleft content hosting)
3 participants