Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Neovim (#2221) #2251

Merged
merged 2 commits into from Jan 3, 2020
Merged

Add Neovim (#2221) #2251

merged 2 commits into from Jan 3, 2020

Conversation

runxel
Copy link
Member

@runxel runxel commented Dec 31, 2019

Issue: Closes #2221

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Logo can be found at their Github repo. Color #57A143 was taken from the flat color version (also in the repo).

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Dec 31, 2019
@PeterShaggyNoble
Copy link
Member

Which version of the logo did you use, @runxel? This is what I get from https://github.com/neovim/neovim.github.io/blob/master/logos/neovim-logo-1color.svg, with your version overlaid in red for comparison.

Neovim

@runxel
Copy link
Member Author

runxel commented Jan 2, 2020

I've corrected an error they made (or maybe it's because svg does not support stroke styles, not sure).
The technical explanation:
When making a closed outline you can choose on which side the resulting line should reside: outside, inside, or middle.
In their svg they didn't converted the outline into a shape, and missed to correct the error that the line is not any longer inside now. This distorts the logo. Just have a look at the flat one e.g. and compare it:
https://github.com/neovim/neovim.github.io/blob/master/logos/neovim-logo-flat.png

(I think my version should be right...)

@PeterShaggyNoble
Copy link
Member

Yep, looks like you're right, @runxel; if, instead of converting that stroke to a path, I remove the stroke and add a fill then things line up perfectly.

Given that, I think this one's good to go so I'll merge it in now. Thanks for your work on it.

Neovim

@PeterShaggyNoble PeterShaggyNoble merged commit f17f6c0 into simple-icons:develop Jan 3, 2020
@runxel runxel deleted the neovim branch January 3, 2020 18:06
ericcornelissen added a commit that referenced this pull request Jan 7, 2020
# New icons

- GNU Bash (#2185)
- Z-Wave (#2212)
- Convertio (#2213)
- Material UI (#2211)
- Datadog (#2231)
- Audiomack (#2230)
- New York Times (#2224)
- EA (#2237)
- Square Enix (#2236)
- Authy (#2233)
- Activision (#2235)
- ActiGraph (#2234)
- Celery (#2110)
- Photocrowd (#2193)
- WebAssembly (#2244)
- Alipay (#2241)
- ZDF (#2199)
- NDR (#2200)
- Sat.1 (#2203)
- TELE5 (#2206)
- Battle.net (#2215)
- Phonegap (#2247)
- GNU Emacs (#2248)
- Corona Engine (#2245)
- Asciinema (#2218)
- RTLZWEI (#2202)
- figshare (#2220)
- Tomorrowland (#2217)
- iFood (#2209)
- Litecoin (#2210)
- Freelancer (#2254)
- Fandom (#2263)
- Unicode (#2257)
- Pexels (#2261)
- Airtable (#2274)
- XMPP (#2085, #2275)
- Red Hat Open Shift (#2277)
- FITE (#2262)
- Qi (#2255)
- Sencha (#2246)
- Neovim (#2251)
- Qualtrics (#2285)
- VMware (#2265)

# Updated icons

- JSFiddle (#2214)
- Campaign Monitor (#2259)
- Helm (#2273)
- Accusoft (#2291)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neovim (text editor)
2 participants