Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GNU Bash #2185

Merged
merged 3 commits into from Dec 27, 2019
Merged

Add GNU Bash #2185

merged 3 commits into from Dec 27, 2019

Conversation

runxel
Copy link
Member

@runxel runxel commented Dec 19, 2019

Issue:
Closes #2183

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The logo is from their github repo.
The color #4EAA25 is from the style guide. But I would also be okay with #293137.

@runxel runxel added the new icon Issues or pull requests for adding a new icon label Dec 19, 2019
@foo-dogsquared
Copy link
Contributor

Just for clarification, what file from the repo did you use to make the PR (e.g., the EPS, SVG)?

Apparently, some of the SVGs from the official repo are a bit malformed.

Here's the 48x48.svg from the repo. (Take note of the bottom edge.)
2019-12-20-03-28-32

Here's the 512x512.svg from the repo.
2019-12-20-03-28-47

Here's the 24x24.svg file overlaid with your PR. (No need to compare.)
2019-12-20-03-32-11

@runxel
Copy link
Member Author

runxel commented Dec 19, 2019

I took 24x24_white, which doesn't look too bad, right? 😅

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Dec 19, 2019

There's a monochrome SVG here, if it's any help. But if there are discrepancies/doubts, I'd say go back to the source files.

@foo-dogsquared
Copy link
Contributor

24x24_white.svg also has the same (if not similar) malformation with its colored counterpart.

But compared to the 512x512 versions of the SVG, it's not too bad.
The only (very) minor problem is the pictured part.

2019-12-20-03-51-28

2019-12-20-03-51-19

Now the original Illustrator file is taken as ground truth.
@runxel
Copy link
Member Author

runxel commented Dec 22, 2019

Thanks to the comment of @PeterShaggyNoble now the updated version!
It's taken from the ground truth, their Illustrator file, which also is in the the github repo.

Thanks again for everyone who commented and made this PR better! 🌮

@phatbhoy67
Copy link
Contributor

Thanks for your work on this one @runxel 👍

@phatbhoy67 phatbhoy67 merged commit fb14e01 into simple-icons:develop Dec 27, 2019
@runxel runxel deleted the bash branch December 27, 2019 11:20
ericcornelissen added a commit that referenced this pull request Jan 7, 2020
# New icons

- GNU Bash (#2185)
- Z-Wave (#2212)
- Convertio (#2213)
- Material UI (#2211)
- Datadog (#2231)
- Audiomack (#2230)
- New York Times (#2224)
- EA (#2237)
- Square Enix (#2236)
- Authy (#2233)
- Activision (#2235)
- ActiGraph (#2234)
- Celery (#2110)
- Photocrowd (#2193)
- WebAssembly (#2244)
- Alipay (#2241)
- ZDF (#2199)
- NDR (#2200)
- Sat.1 (#2203)
- TELE5 (#2206)
- Battle.net (#2215)
- Phonegap (#2247)
- GNU Emacs (#2248)
- Corona Engine (#2245)
- Asciinema (#2218)
- RTLZWEI (#2202)
- figshare (#2220)
- Tomorrowland (#2217)
- iFood (#2209)
- Litecoin (#2210)
- Freelancer (#2254)
- Fandom (#2263)
- Unicode (#2257)
- Pexels (#2261)
- Airtable (#2274)
- XMPP (#2085, #2275)
- Red Hat Open Shift (#2277)
- FITE (#2262)
- Qi (#2255)
- Sencha (#2246)
- Neovim (#2251)
- Qualtrics (#2285)
- VMware (#2265)

# Updated icons

- JSFiddle (#2214)
- Campaign Monitor (#2259)
- Helm (#2273)
- Accusoft (#2291)
@5ouma 5ouma mentioned this pull request Sep 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash (shell)
4 participants