Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Cast #2352

Merged
merged 6 commits into from Jan 22, 2020
Merged

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Jan 13, 2020

Google Cast

Issue: Closes #2335

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Possible alternative name: Chromecast

There seems to be a fair few possibilities for the colour. I've gone with the blue in this logo found on this page but it doesn't sit well with me. Colour confirmed here.

@PeterShaggyNoble PeterShaggyNoble added new icon Issues or pull requests for adding a new icon in discussion There is an ongoing discussion that should be finished before we can continue and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Jan 13, 2020
@PeterShaggyNoble PeterShaggyNoble mentioned this pull request Jan 14, 2020
12 tasks
@ericcornelissen ericcornelissen added the pending Issues that are pending because of e.g. a scheduled brand update label Jan 16, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see my comment in the issue.

I don't think "Chromecast" is the correct name for the "brand". When I read Chromecast I think of the physical device first and foremost (although I'm not sure what the logo of that brand is...) not of this icon. I think "Google Cast" (or maybe just "Cast") is the way to go.

@PeterShaggyNoble PeterShaggyNoble changed the title Add Chromecast Add Google Cast Jan 16, 2020
@PeterShaggyNoble
Copy link
Member Author

Updated the name to "Google Cast"; I think "Cast" would be too generic.

@ericcornelissen ericcornelissen removed the pending Issues that are pending because of e.g. a scheduled brand update label Jan 19, 2020
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine to me, I just have a non-blocking comment on the source:

For the colour you reference the Partner Marketing Hub, which also has vector version of the logo. The source you currently specify seems to come from the logo in the header, is that correct? in which case it is a Material Icons. Given earlier discussions and given that the colour comes from the Marketing Hub source, I think it is better if we specify that source (and perhaps check if the SVGs match).

Updated the name to "Google Cast"; I think "Cast" would be too generic

Nice, I agree

@PeterShaggyNoble
Copy link
Member Author

@ericcornelissen, there's a .zip file available for download at the end of the page I provided as the source URL, which is what I based the version in this PR on. Although, the cast icons or one area that Google seem to be very consistent in.

I've been trying to avoid the marketing hub URLs as sources 'cause they're hideous! 😆 But, you're probably right: as both the icon and the colour are available there, we should probably use it in this case. Will update shortly.

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a .zip file available for download at the end of the page I provided as the source URL, which is what I based the version in this PR on.

Thanks for the clarification 🙂 In that case I'm also fine with the current source (i.e. https://developers.google.com/cast/docs/developers).

I've been trying to avoid the marketing hub URLs as sources 'cause they're hideous! 😆

Agreed, that is kind of annoying, that also makes me question if they will be available long term... Perhaps we could use just https://partnermarketinghub.withgoogle.com/#/brands? Less clear where the icon came from, but perhaps more safe....

But, you're probably right: as both the icon and the colour are available there, we should probably use it in this case. Will update shortly.

I will approve this as is, but won't merge in case you still want to update the URL 😉

@PeterShaggyNoble
Copy link
Member Author

I think https://partnermarketinghub.withgoogle.com/#/brands is a good compromise for when we need to use that site as a source, @ericcornelissen. URL updated.

@ericcornelissen ericcornelissen merged commit f0b6b5d into simple-icons:develop Jan 22, 2020
@ericcornelissen
Copy link
Contributor

Thanks @PeterShaggyNoble and thank you once again for the contributions! 🎉

PS. I will look into why the labeling action is failing 😕

@PeterShaggyNoble PeterShaggyNoble deleted the chromecast branch January 22, 2020 11:19
ericcornelissen added a commit that referenced this pull request Feb 5, 2020
# New icons

- Elixir (#2242)
- Cinema4d (#2376)
- SEAT (#2351)
- MAAS (#2391)
- Fila (#2405)
- Ferrari (#2431)
- OpenBSD (#2426)
- Zigbee (#2382)
- Google Translate (#2430)
- LG (#2401)
- FIFA (#2404)
- Fluentd (#2415)
- Google Messages (#2367)
- JCB (#2389)
- Google Cast (#2352)
- Vuetify (#2417)
- Spinnaker icon (#2443)
- Microsoft SQL Server (#2453, 5c9c622)
- pr.co (#2456)
- Khronos Group (#2448)
- OpenGL (#2450)
- Vulkan (#2451)
- WebGL (#2452)
- WebRTC (#2454)
- Symphony (#2468)
- Veritas (#2326)
- Beatport (#2471)
- Hugo (#2455)
- Font Awesome (#2447)
- pre-commit (#2476)
- Aircall (#2466)
- Apache ECharts (#2473)
- WooCommerce (#2461)
- MIDI (#2483)
- Serverless (#2484)
- Woo (#2479)
- Katana (#2497)
- Houdini (#2498)
- Google Cardboard (#2502)
- Nuke (#2496)
- Concourse (#2427)
- NixOS (#2429)
- MariaDB (#2506)
- MariaDB Foundation (#2402)
- Google Classroom (#2482)
- Open Containers Initiative (#2490)
- Fastly (#2500)
- Peugeot (#2515)
- WP Rocket (#2432)
- Affinity Photo (#2423)
- Google Nearby (#2508)
- haveibeenpwned (#2517)
- Ferrari Corp (#2360)
- Affinity Designer (#2422)
- LabVIEW (#2435)
- Affinity Publisher (#2424)
- Affinity (#2425)
- NFC (#2501)

# Updated icons

- Twitch (#2118)
- Pandora (#2428)
- Babel (#2499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Cast
2 participants