Add Google Messages #2367
Merged
Add Google Messages #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterShaggyNoble
added
the
new icon
There was a problem hiding this comment.
Also see my comment in the issue.
On the topic of this PR, why did you choose "Messages by Google" as title? The app itself is called just "Messages", which is perhaps not a suitable name as it is somewhat generic, but why not "Google Messages"?
|
I couldn't decide between those two, @ericcornelissen ("Messages" was obviously, as you say, too generic) so went with the one they use in the |
ericcornelissen
approved these changes
Jan 16, 2020
|
I think this is good to merge, thanks for your work on this one @PeterShaggyNoble and for review @ericcornelissen 👍 👍 |
ericcornelissen
added a commit
that referenced
this pull request
Feb 5, 2020
# New icons - Elixir (#2242) - Cinema4d (#2376) - SEAT (#2351) - MAAS (#2391) - Fila (#2405) - Ferrari (#2431) - OpenBSD (#2426) - Zigbee (#2382) - Google Translate (#2430) - LG (#2401) - FIFA (#2404) - Fluentd (#2415) - Google Messages (#2367) - JCB (#2389) - Google Cast (#2352) - Vuetify (#2417) - Spinnaker icon (#2443) - Microsoft SQL Server (#2453, 5c9c622) - pr.co (#2456) - Khronos Group (#2448) - OpenGL (#2450) - Vulkan (#2451) - WebGL (#2452) - WebRTC (#2454) - Symphony (#2468) - Veritas (#2326) - Beatport (#2471) - Hugo (#2455) - Font Awesome (#2447) - pre-commit (#2476) - Aircall (#2466) - Apache ECharts (#2473) - WooCommerce (#2461) - MIDI (#2483) - Serverless (#2484) - Woo (#2479) - Katana (#2497) - Houdini (#2498) - Google Cardboard (#2502) - Nuke (#2496) - Concourse (#2427) - NixOS (#2429) - MariaDB (#2506) - MariaDB Foundation (#2402) - Google Classroom (#2482) - Open Containers Initiative (#2490) - Fastly (#2500) - Peugeot (#2515) - WP Rocket (#2432) - Affinity Photo (#2423) - Google Nearby (#2508) - haveibeenpwned (#2517) - Ferrari Corp (#2360) - Affinity Designer (#2422) - LabVIEW (#2435) - Affinity Publisher (#2424) - Affinity (#2425) - NFC (#2501) # Updated icons - Twitch (#2118) - Pandora (#2428) - Babel (#2499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Closes #2357
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
See #2357 for alternative icon & name options