Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add haveibeenpwned icon (#2516) #2517

Merged
merged 2 commits into from Feb 3, 2020
Merged

Conversation

phatbhoy67
Copy link
Contributor

Issue: #2516

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Manual vector based on favicon.

favicon

Hex value chosen is #191919from the website.

@ericcornelissen ericcornelissen added the new icon Issues or pull requests for adding a new icon label Feb 3, 2020
@ericcornelissen
Copy link
Contributor

ericcornelissen commented Feb 3, 2020

@phatbhoy67 may I ask why you went with a manual vectorization instead of using Calibri to type "';--" into a whatever software you use and convert it to a path from that? I saw that the favicon is slightly different (possibly because it is a rasterized image), but if that is the only reason I think using the icon in the header of the website as a source is better 🤔

@phatbhoy67
Copy link
Contributor Author

Hey @ericcornelissen I did start out with typing the text in Calibri, converting it to path and then used the bottom part of the semicolon (inverted and reversed) to replace the ' to match the design of the favicon. I also used the favicon as a basis to adjust the character spacing.

That's why I described it as "Manual vector based on favicon."

My thinking is that the favicon is a deliberate design, whereas the icon in the header is dependent on CSS rules (including fallback fonts), which means it might not be rendered exactly the same for everyone.

The og:image (https://haveibeenpwned.com/Content/Images/SocialLogo.png) 👇 for the front page also uses a similar version to the favicon.
og-image

Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification @phatbhoy67 👌 In that case I approve of this but will leave it to a second pair of eyes to confirm the colour (@simple-icons/maintainers)

@runxel
Copy link
Member

runxel commented Feb 3, 2020

Yeah I am not too sure about the color either.
Why not some of the blue tones? Would have expected that... 🤔

@phatbhoy67
Copy link
Contributor Author

Why not some of the blue tones?

I found a lot of blue/shades of blue, but none seem to be favoured over the other and buttons/highlights/CTAs etc all use different colours.

Do you have a favourite from the blue options I found @runxel? 👇

#2A6379is the calculated midpoint of gradient #0F1932 to #45ACBF front page.

Other blues include #3a9ac4, #2e82a7, #2b5766, #337ab7, #2e6da4, #1a8cff.

I chose #191919 because it is used consistently across the site as the background colour and is similar to the favicon colour.

@runxel
Copy link
Member

runxel commented Feb 3, 2020

True, no easy decision overall! :)
But since there is so much blue I'd still tend to use one. I like the gradient midpoint!

Copy link
Member

@runxel runxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good work! 👍

@runxel runxel merged commit 3880aaf into simple-icons:develop Feb 3, 2020
@phatbhoy67 phatbhoy67 deleted the hibp branch February 3, 2020 18:49
@PeterShaggyNoble
Copy link
Member

I would have suggested going with the boxed version here as they also have one surrounding the full "logo", underneath the main header.

@ericcornelissen
Copy link
Contributor

That is a decent argument in favor of the border, I initially didn't think it mattered one way or the other but that is definitely an argument in favor of the border 🤔 Good point @PeterShaggyNoble, any other opinions @simple-icons/maintainers?

@wolframroesler
Copy link

Great work, and super fast, thanks! (on behalf of KeePassXC where we're going to use it, cf. keepassxreboot/keepassxc#1083)

ericcornelissen added a commit that referenced this pull request Feb 5, 2020
# New icons

- Elixir (#2242)
- Cinema4d (#2376)
- SEAT (#2351)
- MAAS (#2391)
- Fila (#2405)
- Ferrari (#2431)
- OpenBSD (#2426)
- Zigbee (#2382)
- Google Translate (#2430)
- LG (#2401)
- FIFA (#2404)
- Fluentd (#2415)
- Google Messages (#2367)
- JCB (#2389)
- Google Cast (#2352)
- Vuetify (#2417)
- Spinnaker icon (#2443)
- Microsoft SQL Server (#2453, 5c9c622)
- pr.co (#2456)
- Khronos Group (#2448)
- OpenGL (#2450)
- Vulkan (#2451)
- WebGL (#2452)
- WebRTC (#2454)
- Symphony (#2468)
- Veritas (#2326)
- Beatport (#2471)
- Hugo (#2455)
- Font Awesome (#2447)
- pre-commit (#2476)
- Aircall (#2466)
- Apache ECharts (#2473)
- WooCommerce (#2461)
- MIDI (#2483)
- Serverless (#2484)
- Woo (#2479)
- Katana (#2497)
- Houdini (#2498)
- Google Cardboard (#2502)
- Nuke (#2496)
- Concourse (#2427)
- NixOS (#2429)
- MariaDB (#2506)
- MariaDB Foundation (#2402)
- Google Classroom (#2482)
- Open Containers Initiative (#2490)
- Fastly (#2500)
- Peugeot (#2515)
- WP Rocket (#2432)
- Affinity Photo (#2423)
- Google Nearby (#2508)
- haveibeenpwned (#2517)
- Ferrari Corp (#2360)
- Affinity Designer (#2422)
- LabVIEW (#2435)
- Affinity Publisher (#2424)
- Affinity (#2425)
- NFC (#2501)

# Updated icons

- Twitch (#2118)
- Pandora (#2428)
- Babel (#2499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants