Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nuke (#2495) #2496

Merged
merged 3 commits into from Jan 30, 2020
Merged

Add Nuke (#2495) #2496

merged 3 commits into from Jan 30, 2020

Conversation

runxel
Copy link
Member

@runxel runxel commented Jan 28, 2020

Issue:
Closes #2495

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG was taken from the websites header.

Closes simple-icons#2495
SVG was taken from the websites header.
@runxel runxel added the new icon Issues or pull requests for adding a new icon label Jan 28, 2020
@PeterShaggyNoble
Copy link
Member

There's a minor issue in the top left of the inner circle, that's also present in the original. Don't know if you want to fix it but we could probably do with having a broader discussion on whether or not we should be fixing imperfections in officially sourced graphics.

image

@runxel
Copy link
Member Author

runxel commented Jan 29, 2020

Oh good catch.
Well yeah, let's fix that. At least I always did so. Think of Neovim e.g.
I'm always in favor of fixing. It helps to reduce visual complexity, bandwidth, and processing power.

@PeterShaggyNoble
Copy link
Member

Looks like something went wrong there, @runxel (yours in red, original in green).

image

@runxel
Copy link
Member Author

runxel commented Jan 29, 2020

Baffling!

@PeterShaggyNoble
Copy link
Member

Looks good to me now, @runxel. Nice work 👍

@PeterShaggyNoble PeterShaggyNoble merged commit 0df8830 into simple-icons:develop Jan 30, 2020
@runxel runxel deleted the fnuke branch January 30, 2020 14:50
ericcornelissen added a commit that referenced this pull request Feb 5, 2020
# New icons

- Elixir (#2242)
- Cinema4d (#2376)
- SEAT (#2351)
- MAAS (#2391)
- Fila (#2405)
- Ferrari (#2431)
- OpenBSD (#2426)
- Zigbee (#2382)
- Google Translate (#2430)
- LG (#2401)
- FIFA (#2404)
- Fluentd (#2415)
- Google Messages (#2367)
- JCB (#2389)
- Google Cast (#2352)
- Vuetify (#2417)
- Spinnaker icon (#2443)
- Microsoft SQL Server (#2453, 5c9c622)
- pr.co (#2456)
- Khronos Group (#2448)
- OpenGL (#2450)
- Vulkan (#2451)
- WebGL (#2452)
- WebRTC (#2454)
- Symphony (#2468)
- Veritas (#2326)
- Beatport (#2471)
- Hugo (#2455)
- Font Awesome (#2447)
- pre-commit (#2476)
- Aircall (#2466)
- Apache ECharts (#2473)
- WooCommerce (#2461)
- MIDI (#2483)
- Serverless (#2484)
- Woo (#2479)
- Katana (#2497)
- Houdini (#2498)
- Google Cardboard (#2502)
- Nuke (#2496)
- Concourse (#2427)
- NixOS (#2429)
- MariaDB (#2506)
- MariaDB Foundation (#2402)
- Google Classroom (#2482)
- Open Containers Initiative (#2490)
- Fastly (#2500)
- Peugeot (#2515)
- WP Rocket (#2432)
- Affinity Photo (#2423)
- Google Nearby (#2508)
- haveibeenpwned (#2517)
- Ferrari Corp (#2360)
- Affinity Designer (#2422)
- LabVIEW (#2435)
- Affinity Publisher (#2424)
- Affinity (#2425)
- NFC (#2501)

# Updated icons

- Twitch (#2118)
- Pandora (#2428)
- Babel (#2499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuke
2 participants