Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SFML #4678

Merged
merged 4 commits into from Jan 25, 2021
Merged

Add SFML #4678

merged 4 commits into from Jan 25, 2021

Conversation

MiguelMJ
Copy link
Contributor

@MiguelMJ MiguelMJ commented Jan 7, 2021

Issue: Closes #3594
Alexa rank: ~385k

image

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

It was pretty straightforward, because the logo is already provided in SVG. I only merged paths and removed colors. The hex color is the same used in the background of different elements inspected on the official website, that is the same as the mean of the gradient of the logo.

Note that the logo is public domain (source)

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 7, 2021
icons/sfml.svg Outdated Show resolved Hide resolved
@MiguelMJ
Copy link
Contributor Author

Okey, this time the problem was that the colinear segments I deleted were precisely the one causing the new problem (due to the change in the precision to 4). So to fix that I didn't remove the colinear segments, but adapted them to the new precision.
This time I checked against the real logo, I hope it worked hahaha.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks loads better! Thanks @MiguelMJ 🎉

I am however seeing a load of unnecessary points (see image below) that could potentially be removed to simplify the path and bring the file size down a bit. Did you want to take a look at this yourself, or would you like me to see what I can do with the points?

image

@MiguelMJ
Copy link
Contributor Author

I can do it, thanks for the patience! 😅

@MiguelMJ
Copy link
Contributor Author

image

I removed as many points as possible keeping the original shape. I think there's no more I can do, so if you want to take a look yourself, feel free 😄

Thank you very much!

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I tried simplifying further but there was too much difference to the original icon. Nice work @MiguelMJ 💪🏻

@adamrusted adamrusted merged commit 880c706 into simple-icons:develop Jan 25, 2021
@MiguelMJ MiguelMJ deleted the sfml branch January 25, 2021 17:28
ericcornelissen added a commit that referenced this pull request Jan 31, 2021
# New Icons

- Aeroméxico (#4760)
- Air China (#4799)
- Alibaba Cloud (#4819)
- Amazon Pay (#4793)
- BBC (#4846)
- Chainlink (#4857)
- Chakra UI (#4851)
- China Southern Airlines (#4837)
- CountingWorks PRO (#4796)
- Delta (#4844)
- Emirates (#4862)
- Falcon (#4841)
- Jamstack (#4831)
- macOS (#4867)
- NASA (#4850)
- Nrwl (#4859)
- Okta (#4852)
- OYO (#4840)
- Premier League (#4753)
- Redux-Saga (#4803)
- Screencastify (#4806)
- SFML (#4678)
- Statuspal (#4823)
- stylelint (#4838)
- Tampermonkey (#4843)
- TV Time (#4766)
- Vector Logo Zone (#4842)
- Vectorworks (#4764)
- Zoiper (#4854)

# Updated Icons

- Anchor (#4880)
- Google AdSense (#4472)
- Google News (#4474)
- Google Scholar (#4686)
- Google Translate (#4584)
- Opel (#4813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: SFML icon
3 participants