Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylelint icon #4838

Merged
merged 2 commits into from Jan 29, 2021
Merged

Conversation

service-paradis
Copy link
Member

image

Issue: N/A
Alexa rank: ~251k and 8.4k ⭐ on Github

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 22, 2021
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Is it worth linking to https://github.com/stylelint/stylelint/tree/1f7bbb2d189b3e27b42de25f2948e3e5eec1b759/identity as the source, just so we've got the specific version on file?

@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 26, 2021
@service-paradis
Copy link
Member Author

I never know if I should use a source where we can potentially look in the future if the logo have been updated or if I should link to the specific file in used 😅

@PeterShaggyNoble
Copy link
Member

  1. For GitHub sources link to the specific commit of the file. Unless the repo also contains their brand guidelines, in which case link to the repo.
  2. For Wikipedia & Wikimedia, link to the source file's page.
  3. For all other sources, try to link to a page that includes the source file. Sometimes, though, linking directly to the file is unavoidable.

So, in this case, assuming you based your version on the black icon, the source URL should be https://github.com/stylelint/stylelint/blob/1f7bbb2d189b3e27b42de25f2948e3e5eec1b759/identity/stylelint-icon-black.svg

@service-paradis
Copy link
Member Author

Done 😃

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @service-paradis 💯

@adamrusted adamrusted merged commit 601a1a8 into simple-icons:develop Jan 29, 2021
@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jan 29, 2021
@service-paradis service-paradis deleted the add-stylelint branch January 30, 2021 19:40
ericcornelissen added a commit that referenced this pull request Jan 31, 2021
# New Icons

- Aeroméxico (#4760)
- Air China (#4799)
- Alibaba Cloud (#4819)
- Amazon Pay (#4793)
- BBC (#4846)
- Chainlink (#4857)
- Chakra UI (#4851)
- China Southern Airlines (#4837)
- CountingWorks PRO (#4796)
- Delta (#4844)
- Emirates (#4862)
- Falcon (#4841)
- Jamstack (#4831)
- macOS (#4867)
- NASA (#4850)
- Nrwl (#4859)
- Okta (#4852)
- OYO (#4840)
- Premier League (#4753)
- Redux-Saga (#4803)
- Screencastify (#4806)
- SFML (#4678)
- Statuspal (#4823)
- stylelint (#4838)
- Tampermonkey (#4843)
- TV Time (#4766)
- Vector Logo Zone (#4842)
- Vectorworks (#4764)
- Zoiper (#4854)

# Updated Icons

- Anchor (#4880)
- Google AdSense (#4472)
- Google News (#4474)
- Google Scholar (#4686)
- Google Translate (#4584)
- Opel (#4813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants