added onnx icon #5472
added onnx icon #5472
Conversation
github-actions
bot
added
the
new icon
|
Welcome to Simple Icons, @lukesalamone and thanks for taking this one on 🙂 Note that the SVG you mentioned in the original issue isn't quite square, it's wider than it is high, so when resizing the width to I'm not sure what we should be using for the colour; from their website I'd personally expect a blue but they use many different shades without any clear preference for one over the others. Also, for GitHub source URLs, we use the commit URL which, in this case, would be https://github.com/onnx/onnx.github.io/blob/382e7036b616ce1555499ac41730245a2478513c/images/ONNX-ICON.svg |
|
Thanks for the update, @lukesalamone. However, I'm seeing a few small differences such as this one in the upper right between your version (in red) and the source SVG. Would you mind having another look at it to see if you can fix those up? |
|
There may be a misalignment due to the size and centering requirements of the linter. If there are additional requirements please add them to the contribution guidelines. I am not an expert on SVGs so I don't know how to resolve this issue. The icon is sized such that its largest dimension (width) is exactly 24. To meet the centering requirements of the linter, I shifted it left by 0.001. |
|
That comparison was done after resizing and centring the original, @lukesalamone so that wouldn't account for the differences. I think it may be an issue with the precision during the optimisation process as, after recreating the icon myself and optimising with a precision of 3, there was a marked difference in the dimensions - the width dropped to Alternatively, if you want to use it, here's my final path: |
|
Thanks for updating, @lukesalamone. As you're using my path now, though, we'll need a review from one of the other @simple-icons/maintainers before merging. |
There was a problem hiding this comment.
Comparing directly to the source (black) in Illustrator, I'm seeing quite a few inconsistencies in both the PR, in red and @PeterShaggyNoble's path, in green.
The below path is passing the linter with 4 decimals, and matches up to source - though it's probably worth another @simple-icons/maintainers checking that before you put the work into updating the PR @lukesalamone 😅
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>ONNX icon</title><path d="M23.0841 11.2929h-.1369L18.887 3.9023c.0912-.1369.0912-.2737.0912-.4562 0-.5474-.4562-.958-.958-.958-.2737 0-.5474.1369-.6843.3193L9.3066 1.1651C9.261.6632 8.8504.2983 8.3486.2983c-.5474 0-.958.4562-.958.958 0 .1825.0456.3193.0912.4562l-6.25 8.9873c-.0912 0-.1825-.0456-.2737-.0456-.5474 0-.958.4562-.958.958 0 .5475.4562.958.958.958h.0456l3.3759 8.3486c-.0456.1369-.0912.2737-.0912.4106 0 .5475.4562.958.958.958.2737 0 .5474-.1369.6843-.3193l10.1278 1.0037c.0912.4106.5018.7299.958.7299.5475 0 .958-.4562.958-.958 0-.2281-.0912-.4562-.2281-.6387l5.1095-8.8961h.1825c.5474 0 .958-.4562.958-.958.0458-.5018-.3648-.958-.9123-.958zm-5.8394-7.2537c.1369.1369.2737.2737.4562.3193l-1.5511 11.5877c-.0912 0-.1825.0456-.2737.0912L7.4362 8.7381c0-.0912.0456-.1825.0456-.2737v-.1825l9.7629-4.2427zm4.8814 8.5311-5.2008 3.5584c-.0456-.0456-.0912-.0456-.1369-.0912l1.5967-11.6789 3.969 7.2993c-.1369.1825-.2281.4106-.2281.6387-.0455.0912.0001.1824.0001.2737zM6.3869 7.5064c-.4562.0912-.8212.4562-.8212.958V8.51l-3.4672 2.0529L7.4818 2.853 6.3869 7.5064zm.365 1.916c.1369-.0456.2737-.0912.365-.1369l8.3486 7.2537c-.0456.0912-.0456.2281-.0456.365v.0456L6.0676 20.782c-.1369-.1825-.365-.365-.5931-.4106l1.2774-10.949zm8.896 8.1205c.1369.1369.3193.2281.5018.2737l.4562 4.0603c-.1825.0912-.365.2737-.4562.4562l-9.8085-.958 9.3067-3.8322zm1.1862.2281c.3193-.1369.5474-.5018.5474-.8668 0-.0912 0-.1825-.0456-.2281l4.7446-3.2391-4.7902 8.303-.4562-3.969zm.2281-14.3705-9.8997 4.334c-.0457-.0457-.0913-.0457-.0913-.0913L8.3486 2.26h.0456c.365 0 .6387-.1825.8212-.4562l7.8468 1.5967zM1.9617 11.6122v-.1825L5.8851 9.103c.0912.0912.1825.1369.2737.1825l-1.2774 10.949-3.1934-7.8923c.1368-.1825.2737-.4106.2737-.73z"/></svg>
|
OK, there is definitely something very weird going on here 🤔 I'm seeing these differences when comparing @adamrusted's version (in red) to the original but, after quarduple checking, I'm not seeing the differences in my version. Think we're going to need another pair of eyes here! |
|
Did you intend to merge this, @service-paradis? |
Oops 😅 |
# New Icons - Adafruit (#5592) - Alpine.js (#5607) - BookBub (#5435) - FFmpeg (#5537) - Google Fonts (#5207) - IOTA (#5520) - Lit (#5571) - Odysee (#5577) - ONNX (#5472) - OpenWrt (#5576) - Purism (#5462) - Pusher (#5568) - Telegraph (#5501) - Thingiverse (#5591) - UFC (#5569) # Updated Icons - Ford (#5564) - Hack The Box (#5555) - Hackaday (#5555) - HackHands (#5555) - Hackster (#5555) - Handshake (#5555) - Handshake (#5555) - Harbor (#5555) - Hashnode (#5555) - Haskell (#5555) - Hasura (#5555) - Haxe (#5555) - HBO (#5555) - HCL (#5555) - Headspace (#5555) - HelpDesk (#5555) - HERE (#5555) - Heroku (#5555) - Hexo (#5555) - Hilton (#5555) - HipChat (#5555) - HockeyApp (#5555) - Home Assistant (#5555) - Home Assistant Community Store (#5555) - HomeAdvisor (#5555) - Homebrew (#5555) - Hootsuite (#5555) - Hoppscotch (#5555) - Houzz (#5555) - HP (#5555) - Huawei (#5555) - HubSpot (#5555) - Hugo (#5555) - Hulu (#5555) - Humble Bundle (#5555) - Hypothesis (#5555) - Hyundai (#5555) - ICON (#5519) - Transport for Ireland (#5621) - Transport for London (#5621)
Brand Name: ONNX
Website: onnx.ai
Alexa rank: 480,199
Official resources for icon and color:
https://github.com/onnx/onnx
Issue:
#5391
Alexa rank: 480,199
However their github repository has over 10k stars.
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description