Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Odysee #5577

Merged
merged 1 commit into from May 6, 2021
Merged

Add Odysee #5577

merged 1 commit into from May 6, 2021

Conversation

foo-dogsquared
Copy link
Contributor

image

Issue: #5058
Alexa rank: ~3.8k (as of 2021-04-31)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The hex value is the first stop value for the gradient and similar colors can be found on the site so I picked that.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 30, 2021
@adamrusted adamrusted linked an issue Apr 30, 2021 that may be closed by this pull request
@PeterShaggyNoble
Copy link
Member

Nice work, @foo-dogsquared 👍🏻 You fared better with the stars than I did; took a few stabs at it and no matter what I did with them and in which order there was always at least one of them jumping all over the place. The is a tiny hairline down the left edge of the star under the arm on the left when comparing yours (in red) with the original. It's insignificant enough, though, that I'd be OK to run with it if it can't be cleaned up with too much hassle.

I agree with the choice of pink for the colour but would #fa6165 be a better choice seeing as its variable name in their stylesheet is --color-primary?

@foo-dogsquared
Copy link
Contributor Author

The is a tiny hairline down the left edge of the star under the arm on the left when comparing yours (in red) with the original. It's insignificant enough, though, that I'd be OK to run with it if it can't be cleaned up with too much hassle.

Thank goodness. It took me an embarrassingly long time than I initially expected just to get it right. :p

I agree with the choice of pink for the colour but would #fa6165 be a better choice seeing as its variable name in their stylesheet is --color-primary?

The website does have two themes (light and dark) with different --color-primary values. Both of the --color-primary values are closer to the colors from the original icon vector file. I don't know what to pick from them. For now I'll be sticking to my choice since it is also of the color from the favicon.

@PeterShaggyNoble
Copy link
Member

It took me an embarrassingly long time than I initially expected just to get it right

Sounds like you had as much fun with it as I did! 😆

The website does have two themes (light and dark) with different --color-primary values

Ah, in that case then it's definitely not teh primary brand colour. Still not 100% convinced with our colour choice but as it is used in the favicon and in the absence of anything else to go on, let's run with it for now.

Thanks, @foo-dogsquared 👍🏻

@PeterShaggyNoble PeterShaggyNoble merged commit eb37e32 into simple-icons:develop May 6, 2021
ericcornelissen added a commit that referenced this pull request May 9, 2021
# New Icons

- Adafruit (#5592)
- Alpine.js (#5607)
- BookBub (#5435)
- FFmpeg (#5537)
- Google Fonts (#5207)
- IOTA (#5520)
- Lit (#5571)
- Odysee (#5577)
- ONNX (#5472)
- OpenWrt (#5576)
- Purism (#5462)
- Pusher (#5568)
- Telegraph (#5501)
- Thingiverse (#5591)
- UFC (#5569)

# Updated Icons

- Ford (#5564)
- Hack The Box (#5555)
- Hackaday (#5555)
- HackHands (#5555)
- Hackster (#5555)
- Handshake (#5555)
- Handshake (#5555)
- Harbor (#5555)
- Hashnode (#5555)
- Haskell (#5555)
- Hasura (#5555)
- Haxe (#5555)
- HBO (#5555)
- HCL (#5555)
- Headspace (#5555)
- HelpDesk (#5555)
- HERE (#5555)
- Heroku (#5555)
- Hexo (#5555)
- Hilton (#5555)
- HipChat (#5555)
- HockeyApp (#5555)
- Home Assistant (#5555)
- Home Assistant Community Store (#5555)
- HomeAdvisor (#5555)
- Homebrew (#5555)
- Hootsuite (#5555)
- Hoppscotch (#5555)
- Houzz (#5555)
- HP (#5555)
- Huawei (#5555)
- HubSpot (#5555)
- Hugo (#5555)
- Hulu (#5555)
- Humble Bundle (#5555)
- Hypothesis (#5555)
- Hyundai (#5555)
- ICON (#5519)
- Transport for Ireland (#5621)
- Transport for London (#5621)
@foo-dogsquared foo-dogsquared deleted the odysee branch June 22, 2021 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odysee icon (LBRY frontend / rebrand?)
2 participants