Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pusher icon #5568

Merged
merged 5 commits into from May 4, 2021
Merged

Add Pusher icon #5568

merged 5 commits into from May 4, 2021

Conversation

adempus
Copy link
Contributor

@adempus adempus commented Apr 29, 2021 •
edited

pusher

Issue: #5538
Alexa rank: 15,052

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

  • Woot! First pull request! 🎉
  • Added just the primary icon and JSON object for Pusher.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 29, 2021
@adempus
fixed icon size of path to be exactly 24 in one dimension, previously…
48f166f 
… (15.56 x 24.015). Fixed path to center at (12, 12), previously (11.95, 12.036)
adempus
adempus commented Apr 30, 2021
View reviewed changes
Copy link
Contributor Author

@adempus adempus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed icon size of path to be exactly 24 in one dimension, previously (15.56 x 24.015). Fixed path to center at (12, 12), previously (11.95, 12.036)

adamrusted
adamrusted requested changes May 2, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @adempus!
I'm currently seeing some differences around the edges when comparing - which may just be down to a precision thing. Could you rebuild this from the source file, using a precision of 4, and see if that fixes the issue?

@adempus adempus requested a review from adamrusted May 2, 2021 19:49
adamrusted
adamrusted requested changes May 3, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @adempus - though it appears the icon is still in 3 decimals, and having similar issues. In order to get it up to 4 decimals, you'll need to start from scratch on the icon, as trying to add decimals to a path that's already optimized to 3 decimals will keep it at 3. If you're using the NPM scripts, you can edit the svgo.config.js file, to set the floatPrecision to 4 - though be careful not to include that updated file in your PR!

@adamrusted adamrusted linked an issue May 3, 2021 that may be closed by this pull request
Icon Request - Pusher #5538
Closed
@adempus adempus requested a review from adamrusted May 3, 2021 20:01
@adempus
Copy link
Contributor Author

adempus commented May 3, 2021

Thanks for the update @adempus - though it appears the icon is still in 3 decimals, and having similar issues. In order to get it up to 4 decimals, you'll need to start from scratch on the icon, as trying to add decimals to a path that's already optimized to 3 decimals will keep it at 3. If you're using the NPM scripts, you can edit the svgo.config.js file, to set the floatPrecision to 4 - though be careful not to include that updated file in your PR!

Ah, that explains why the values weren't changing. Started from scratch and set precision to 4. Hopefully that fixes it.

@adempus adempus closed this May 3, 2021
@adempus adempus reopened this May 3, 2021
adamrusted
adamrusted approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @adempus 🚀

@adamrusted adamrusted merged commit 475fc9d into simple-icons:develop May 4, 2021
@github-actions github-actions bot mentioned this pull request May 9, 2021
Merged
ericcornelissen added a commit that referenced this pull request May 9, 2021
@ericcornelissen
Release 15 new icons and 40 updated icons (v4.23.0)
49314d8 
# New Icons

- Adafruit (#5592)
- Alpine.js (#5607)
- BookBub (#5435)
- FFmpeg (#5537)
- Google Fonts (#5207)
- IOTA (#5520)
- Lit (#5571)
- Odysee (#5577)
- ONNX (#5472)
- OpenWrt (#5576)
- Purism (#5462)
- Pusher (#5568)
- Telegraph (#5501)
- Thingiverse (#5591)
- UFC (#5569)

# Updated Icons

- Ford (#5564)
- Hack The Box (#5555)
- Hackaday (#5555)
- HackHands (#5555)
- Hackster (#5555)
- Handshake (#5555)
- Handshake (#5555)
- Harbor (#5555)
- Hashnode (#5555)
- Haskell (#5555)
- Hasura (#5555)
- Haxe (#5555)
- HBO (#5555)
- HCL (#5555)
- Headspace (#5555)
- HelpDesk (#5555)
- HERE (#5555)
- Heroku (#5555)
- Hexo (#5555)
- Hilton (#5555)
- HipChat (#5555)
- HockeyApp (#5555)
- Home Assistant (#5555)
- Home Assistant Community Store (#5555)
- HomeAdvisor (#5555)
- Homebrew (#5555)
- Hootsuite (#5555)
- Hoppscotch (#5555)
- Houzz (#5555)
- HP (#5555)
- Huawei (#5555)
- HubSpot (#5555)
- Hugo (#5555)
- Hulu (#5555)
- Humble Bundle (#5555)
- Hypothesis (#5555)
- Hyundai (#5555)
- ICON (#5519)
- Transport for Ireland (#5621)
- Transport for London (#5621)
@adempus adempus deleted the add/pusher-icon branch May 15, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon Request - Pusher
2 participants
@adempus @adamrusted