Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IOTA icon #5520

Merged
merged 3 commits into from May 7, 2021
Merged

Add IOTA icon #5520

merged 3 commits into from May 7, 2021

Conversation

Mrcuve0
Copy link
Contributor

@Mrcuve0 Mrcuve0 commented Apr 22, 2021

Issue: Closes #5516
Alexa rank: 48,669 (see https://www.alexa.com/siteinfo/)

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The original logo can be downloaded https://files.iota.org/media/IOTA_Logo.zip
The main hex value from https://www.iota.org/connect/brand
I followed the guidelines, all the tests passed

iota

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 22, 2021
@PeterShaggyNoble
Copy link
Member

Welcome to Simple Icons, @Mrcuve0 and thanks for the contribution 🙂

I think we can get away with using just the swirl here as they make it available in the second slide of the source page. Could you update to that, please?

For the source, you can use https://www.iota.org/connect/brand as well, rather than linking directly to the zip.

You can also omit the url entry from the license entry; that will be generated automatically on our end - the url entry is only needed for "custom" type licenses.

Colour's a bit tricky, based on their guidelines alone, I would agree with your choice of the green but, from their website, it looks to me like the "grays" are the primary colours and the greens the accent colours, what do others think?

@PeterShaggyNoble PeterShaggyNoble added changes requested in discussion There is an ongoing discussion that should be finished before we can continue labels Apr 22, 2021
@Mrcuve0
Copy link
Contributor Author

Mrcuve0 commented Apr 22, 2021

You're completely right, I initially didn't catch the swirl logo and thought only the logo+text was available, I'm adjusting it right now.
As for the color, probably the "10pm" grey-blue is the right choice. As you pointed out the main site (and many other pages) follow variations on those blue-ish tints.

Can I go with the 10pm or shall we wait additional feedback?

@PeterShaggyNoble
Copy link
Member

I'd vote for "Midnight" myself so, given that, you can hold off on updating the colour until we get a few more opinions, if you like, or just run with your choice of "10pm" for now.

@Mrcuve0
Copy link
Contributor Author

Mrcuve0 commented Apr 22, 2021

Updates w/ the swirl and "midnight" theme. I also tested the preview with "10pm" but readability is a mess with that color.
Midnight is the one selected for now, let's wait for feedbacks 😊

  • Midnight:
    iota_midnight

  • 10pm
    iota_10pm

  • Main Green
    iota_main_green

  • Dark Green
    iota_dark_green

@PeterShaggyNoble
Copy link
Member

Thanks for the update, @Mrcuve0. However, I'm noticing some hairline thin differences in the right edges of a few of the circles - see example below of the 3rd circle in the top row of the left-hand "wave" with your version in red.

There could be a couple of causes for this:

  • There could be subtle differences between the 3 source files and I'm not comparing to to the same on you based your icon on - I'm using IOTA Mark Black.svg.
  • The circles are shifting or distorting slightly when combining them all into a single path - as happened to me when I tried unifying them in Inkscape, combining them produced better results.
  • The precision need to be set a little higher during the optimisation process.

On the colour, we don't let how things look in our own use cases influence us*, we go with the primary brand colour or what we can best determine to be the primary brand colour, which isn't clear here. But let's hold off on any further updates to the colour for now, until we get the opinion of a few others. *We're actually in the process of building a new website, changing the layout and design so that icons are no longer sitting on coloured backgrounds for this very reason.

image

@Mrcuve0
Copy link
Contributor Author

Mrcuve0 commented Apr 23, 2021

Wow thanks for the feedback! Sadly I'm a real newbie for what concerns SVGs and Inkscape in general. For instance, I had to search for the steps to complete some of the required operations. So I don't know if I'll be able to find similar differences like the ones you reported for the next iterations.

I used the IOTA Mark White file to produce the iota.svg file I pushed. I also used Ctrl-K (combine) to collect all the paths. Is there a better way to do that particular step? Finally, after having tried svgomg in action I'd be pretty sure it's just matter of increasing the precision over the level 3 as suggested, but as I said I'm definitely no expert 😆

I can try again with the same procedure I did and just changing the precision parameter on svgomg

@PeterShaggyNoble
Copy link
Member

I used the IOTA Mark White file

OK, let me compare against that instead before you do anything else.

I also used Ctrl-K (combine) to collect all the paths. Is there a better way to do that particular step?

"Combine" produced the best results for me too when I tried; there was a lot of movement when I used "Union" (Ctrl + +) instead.

@PeterShaggyNoble
Copy link
Member

Seeing the same difference when comparing against the white version, @Mrcuve0, maybe even slightly more pronounced. The good news, though, is that it's nothing you did wrong; after recreating it myself I was seeing the same differences when I optimised with a precision of 3 but everything lined up perfectly when I increased it to 4 so could you give that a try?

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks spot on to me now, @Mrcuve0, nice work 👍🏻

Gonna merge this in as is with the "midnight" colour and, if someone feels strongly enough that we should be using one of the greens instead, we can address that in a separate PR.

Thanks again for the contribution 🙂

@PeterShaggyNoble PeterShaggyNoble merged commit 1d19025 into simple-icons:develop May 7, 2021
@github-actions github-actions bot removed changes requested in discussion There is an ongoing discussion that should be finished before we can continue labels May 7, 2021
ericcornelissen added a commit that referenced this pull request May 9, 2021
# New Icons

- Adafruit (#5592)
- Alpine.js (#5607)
- BookBub (#5435)
- FFmpeg (#5537)
- Google Fonts (#5207)
- IOTA (#5520)
- Lit (#5571)
- Odysee (#5577)
- ONNX (#5472)
- OpenWrt (#5576)
- Purism (#5462)
- Pusher (#5568)
- Telegraph (#5501)
- Thingiverse (#5591)
- UFC (#5569)

# Updated Icons

- Ford (#5564)
- Hack The Box (#5555)
- Hackaday (#5555)
- HackHands (#5555)
- Hackster (#5555)
- Handshake (#5555)
- Handshake (#5555)
- Harbor (#5555)
- Hashnode (#5555)
- Haskell (#5555)
- Hasura (#5555)
- Haxe (#5555)
- HBO (#5555)
- HCL (#5555)
- Headspace (#5555)
- HelpDesk (#5555)
- HERE (#5555)
- Heroku (#5555)
- Hexo (#5555)
- Hilton (#5555)
- HipChat (#5555)
- HockeyApp (#5555)
- Home Assistant (#5555)
- Home Assistant Community Store (#5555)
- HomeAdvisor (#5555)
- Homebrew (#5555)
- Hootsuite (#5555)
- Hoppscotch (#5555)
- Houzz (#5555)
- HP (#5555)
- Huawei (#5555)
- HubSpot (#5555)
- Hugo (#5555)
- Hulu (#5555)
- Humble Bundle (#5555)
- Hypothesis (#5555)
- Hyundai (#5555)
- ICON (#5519)
- Transport for Ireland (#5621)
- Transport for London (#5621)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOTA Cryptocurrency
2 participants