Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WezTerm icon #7774

Merged
merged 4 commits into from Nov 22, 2023
Merged

Add WezTerm icon #7774

merged 4 commits into from Nov 22, 2023

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Sep 13, 2022

Option 1 Option 2

GitHub stars: https://github.com/wez/wezterm - 5.7k
Resource: https://github.com/wez/wezterm/blob/fe78b5821fc106c1061f4c1cc454ff01e74bf97d/assets/icon/wezterm-icon.svg
Color: #4E49EE Picked from the resource

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 13, 2022
@LitoMore
Copy link
Member Author

@wez Which one do you prefer?

@wez
Copy link

wez commented Sep 15, 2022

Option 1 looks more obviously like the logo as it has the outline that prevents it from looking like a random $W, so I'm leaning more towards that, but I'm honestly on the fence.

I think you should also be aware of wez/wezterm#2396 which is a more complex icon proposed by a member of the community. I haven't made any decisions about that yet.

@LitoMore
Copy link
Member Author

@wez I'd prefer the option 2. In most cases the icon in Simple Icons is used for shields.io.

The option 2 looks better in a badge.

For wez/wezterm#2396, those app icons are not the flat design and in vector format. We should use the current SVG one as reference.

@adamrusted adamrusted added the in discussion There is an ongoing discussion that should be finished before we can continue label Jul 9, 2023
@adamrusted
Copy link
Member

Marking as 'in discussion' as the discussion over on WezTerm's own repo is still ongoing.

@PeterShaggyNoble
Copy link
Member

As discussion on a potential new icon has been going on for over a year now and there's no guarantee it will be adopted, I think we should run with the current icon and update in the future if necessary.

Of the 2 options presented, my vote would would go to the first, with the background as that's the option that was chosen by @wez and it's what's used in the website's header; I don't see the $W in use on its own anywhere without the background.

From the website as well it looks like #7e56c2 could be another option for the colour - @wez; do you have a preference between the 2?

@wez
Copy link

wez commented Nov 20, 2023

Proceeding with the $W here sounds good to me. I do tend to prefer purple over blue. The current icon has a blue-er color for contrast reasons, even though its contrast is admittedly not ideal. I'd be happy with either or both.

@PeterShaggyNoble
Copy link
Member

Thanks for the feedback, @wez 👍🏻 Based on that, I think we can run with everything as-is, and we can easily update the icon and/or colour in the future if you develop a stronger preference for one over the other.

@LitoMore, I'm seeing a souple of hairline thin differences in the 2 inner curves of the $ (original in black below, yours in red), could you have a look at those, please?


@PeterShaggyNoble PeterShaggyNoble added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Nov 21, 2023
@LitoMore
Copy link
Member Author

These differences are pretty slight. We can ignore it.

What do you think? @simple-icons/icon-review

image

@PratyushJayachandran
Copy link
Member

These differences are pretty slight. We can ignore it.

What do you think? @simple-icons/icon-review

Looks pretty spot on to me. Outline view with source superimposed on contribution:
image

@PeterShaggyNoble PeterShaggyNoble merged commit f2f23c8 into simple-icons:develop Nov 22, 2023
3 checks passed
@LitoMore LitoMore deleted the wezterm branch November 23, 2023 07:39
mondeja added a commit that referenced this pull request Nov 26, 2023
# New Icons

- Alamy (#9717)
- AlmaLinux (#9796)
- avianca (#9899)
- Basic Attention Token (#9725)
- Bevy (#7076)
- BitComet (#9563)
- Blockbench (#8060)
- BNB Chain (#9724)
- Boosty (#8897)
- Canvas (#9384)
- CBC (#9881)
- Celestron (#9898)
- Chedraui (#9568)
- Clerk (#9417)
- Crew United (#9354)
- Custom Ink (#9903)
- Depositphotos (#9714)
- Dreamstime (#9716)
- Drizzle (#9606)
- Expedia (#9912)
- Fineco (#9495)
- Google Cloud Spanner (#9472)
- Google Dataflow (#9450)
- Google Dataproc (#9451)
- Google Pub/Sub (#9466)
- Google Tasks (#9580)
- GSMArena.com (#8276)
- Headphone Zone (#9744)
- JitPack (#7701)
- Kick (#8910)
- L'Équipe (#7857)
- LibreOffice Base (#9595)
- Loot Crate (#9875)
- Mahindra (#9908)
- Mailtrap (#8267)
- Medusa (#8324)
- Microsoft Store (#8802)
- NHL (#9887)
- Nordic Semiconductor (#9877)
- NSIS (#7333)
- Odoo (#6980)
- openHAB (#8548)
- OpenTofu (#9607)
- OPPO (#9556)
- Payhip (#8247)
- Phosphor Icons (#9747)
- Pi Network (#9890)
- Pine Script (#9914)
- Polestar (#9627)
- Polygon (#9723)
- PrepBytes (#9904)
- Raycast (#8987)
- Refine (#8842)
- Rive (#9878)
- RTM (#8066)
- Sam's Club (#9577)
- Session (#8246)
- Slint (#9682)
- StockX (#9889)
- Toll (#8203)
- TON (#8249)
- TradingView (#8809)
- Upptime (#9732)
- VictoriaMetrics (#9479)
- Vivint (#9882)
- W3Schools (#9326)
- WazirX (#9742)
- WezTerm (#7774)
- ZebPay (#9743)

# Updated Icons

- Appwrite (#9864)
- B&R Automation (#9338)
- C# (#9528)
- Clubhouse (#9328)
- Hyundai (#9653)
- Proton Mail (#7793)
- Proton VPN (#7795)

# Removed Icons

- (ISC)² (#9390)
- Ableton Live (#9306)
- Acclaim (#9301)
- AddThis (#9371)
- Anchor (#9302)
- AngelList (#9303)
- Angular Universal (#9832)
- AngularJS (#9304)
- Ask Ubuntu (#9294)
- Atom (#9305)
- Badgr (#9336)
- Bath ASU (#9341)
- BBC (#9870)
- BBC iPlayer (#9870)
- byte (#9337)
- Code Review (#9294)
- Deezer (#9856)
- Forestry (#9108)
- Hurriyetemlak (#9706)
- Hyperledger (#9655)
- Jenkins X (#9640)
- JFrog Bintray (#9641)
- LGTM (#9488)
- MediaTemple (#9534)
- Microsoft Office (#9896)
- OpenTF (#9607)
- Sendinblue (#9068)
- SonarSource (#7801)
- Sourcegraph (#9258)
- TNT (#9838)
- Twoo (#9509)
- Untangle (#9459)
- Uploaded (#9837)
- W3C (#9885)
- webhint (#9370)
- WhiteSource (#9369)
- Windi CSS (#9250)
- Winmate (#9367)
- Xilinx (#9190)
- Yahoo! (#9861)
- YOLO (#9836)
- YourTravel.TV (#9182)
- Z-Wave (#9180)
- Zend Framework (#9133)
- ZeroMQ (#9366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants