Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Odoo icon #6980

Merged
merged 19 commits into from Nov 22, 2023
Merged

Add Odoo icon #6980

merged 19 commits into from Nov 22, 2023

Conversation

lucas-louis
Copy link
Contributor

odoo

Issue: #6961
Alexa rank: 1,429

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

The color hex value is from: https://www.odoo.com/page/brand-assets
I optimized the lofo with SVGO

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Dec 24, 2021
dirien
dirien reviewed Dec 25, 2021
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
dirien
dirien previously requested changes Dec 25, 2021
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @lucas-louis,

thanks for this contribution.

I see some differences, maybe up the precision?
image

And i used as reference the original one from Odoo website.

https://odoocdn.com/openerp_website/static/src/img/2016/logos/odoo_logo.svg

@dirien dirien linked an issue Dec 25, 2021 that may be closed by this pull request
Request: Odoo Icon #6961
Closed
LitoMore
LitoMore previously requested changes Aug 15, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@adamrusted This looks not correct in the preview. Could you check those shapes?

@adamrusted
Copy link
Member

Sure can. Bear with.

@LitoMore
Copy link
Member

image

It's kind of weird, the icon width shown in Inkscape is not 24.000 but it passed our CI.

@adamrusted
Copy link
Member

It's kind of weird, the icon width shown in Inkscape is not 24.000 but it passed our CI.

Very odd. The compound paths in this one were really playing up for me...

PratyushJayachandran
PratyushJayachandran approved these changes Sep 14, 2023
View reviewed changes
icons/odoo.svg Show resolved Hide resolved
PratyushJayachandran
PratyushJayachandran previously approved these changes Oct 2, 2023
View reviewed changes
icons/odoo.svg Outdated Show resolved Hide resolved
@PratyushJayachandran
Copy link
Member

@adamrusted @LitoMore please re review the PR

@adamrusted adamrusted removed the request for review from dirien November 18, 2023 13:09
@adamrusted adamrusted self-requested a review November 18, 2023 13:09
adamrusted
adamrusted previously requested changes Nov 18, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@PratyushJayachandran - could you take another look please?

@PratyushJayachandran
Copy link
Member

@PratyushJayachandran - could you take another look please?

I fixed the icon but running into that new line error. Please check the icon again.

@adamrusted adamrusted dismissed stale reviews from dirien, PratyushJayachandran, LitoMore, and themself November 20, 2023 08:40

Outdated

@adamrusted adamrusted removed the request for review from LitoMore November 20, 2023 08:41
adamrusted
adamrusted requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a precision issue here. The paths are a pretty close match, but only slightly out across the board. Could you regenerate using npx svgo icons/odoo.svg --p 4 and see if that gives us a better outcome?

@PratyushJayachandran
Copy link
Member

Looks like there's a precision issue here. The paths are a pretty close match, but only slightly out across the board. Could you regenerate using npx svgo icons/odoo.svg --p 4 and see if that gives us a better outcome?

Done. Please check again :)

@adamrusted adamrusted self-requested a review November 21, 2023 14:57
@adamrusted adamrusted merged commit b8eb021 into simple-icons:develop Nov 22, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 26, 2023
Merged
mondeja added a commit that referenced this pull request Nov 26, 2023
@mondeja
Release 69 new icons and 7 updated icons and 45 removed icons (v10.0.0)
bac6a1d 
# New Icons

- Alamy (#9717)
- AlmaLinux (#9796)
- avianca (#9899)
- Basic Attention Token (#9725)
- Bevy (#7076)
- BitComet (#9563)
- Blockbench (#8060)
- BNB Chain (#9724)
- Boosty (#8897)
- Canvas (#9384)
- CBC (#9881)
- Celestron (#9898)
- Chedraui (#9568)
- Clerk (#9417)
- Crew United (#9354)
- Custom Ink (#9903)
- Depositphotos (#9714)
- Dreamstime (#9716)
- Drizzle (#9606)
- Expedia (#9912)
- Fineco (#9495)
- Google Cloud Spanner (#9472)
- Google Dataflow (#9450)
- Google Dataproc (#9451)
- Google Pub/Sub (#9466)
- Google Tasks (#9580)
- GSMArena.com (#8276)
- Headphone Zone (#9744)
- JitPack (#7701)
- Kick (#8910)
- L'Équipe (#7857)
- LibreOffice Base (#9595)
- Loot Crate (#9875)
- Mahindra (#9908)
- Mailtrap (#8267)
- Medusa (#8324)
- Microsoft Store (#8802)
- NHL (#9887)
- Nordic Semiconductor (#9877)
- NSIS (#7333)
- Odoo (#6980)
- openHAB (#8548)
- OpenTofu (#9607)
- OPPO (#9556)
- Payhip (#8247)
- Phosphor Icons (#9747)
- Pi Network (#9890)
- Pine Script (#9914)
- Polestar (#9627)
- Polygon (#9723)
- PrepBytes (#9904)
- Raycast (#8987)
- Refine (#8842)
- Rive (#9878)
- RTM (#8066)
- Sam's Club (#9577)
- Session (#8246)
- Slint (#9682)
- StockX (#9889)
- Toll (#8203)
- TON (#8249)
- TradingView (#8809)
- Upptime (#9732)
- VictoriaMetrics (#9479)
- Vivint (#9882)
- W3Schools (#9326)
- WazirX (#9742)
- WezTerm (#7774)
- ZebPay (#9743)

# Updated Icons

- Appwrite (#9864)
- B&R Automation (#9338)
- C# (#9528)
- Clubhouse (#9328)
- Hyundai (#9653)
- Proton Mail (#7793)
- Proton VPN (#7795)

# Removed Icons

- (ISC)² (#9390)
- Ableton Live (#9306)
- Acclaim (#9301)
- AddThis (#9371)
- Anchor (#9302)
- AngelList (#9303)
- Angular Universal (#9832)
- AngularJS (#9304)
- Ask Ubuntu (#9294)
- Atom (#9305)
- Badgr (#9336)
- Bath ASU (#9341)
- BBC (#9870)
- BBC iPlayer (#9870)
- byte (#9337)
- Code Review (#9294)
- Deezer (#9856)
- Forestry (#9108)
- Hurriyetemlak (#9706)
- Hyperledger (#9655)
- Jenkins X (#9640)
- JFrog Bintray (#9641)
- LGTM (#9488)
- MediaTemple (#9534)
- Microsoft Office (#9896)
- OpenTF (#9607)
- Sendinblue (#9068)
- SonarSource (#7801)
- Sourcegraph (#9258)
- TNT (#9838)
- Twoo (#9509)
- Untangle (#9459)
- Uploaded (#9837)
- W3C (#9885)
- webhint (#9370)
- WhiteSource (#9369)
- Windi CSS (#9250)
- Winmate (#9367)
- Xilinx (#9190)
- Yahoo! (#9861)
- YOLO (#9836)
- YourTravel.TV (#9182)
- Z-Wave (#9180)
- Zend Framework (#9133)
- ZeroMQ (#9366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratyushJayachandran PratyushJayachandran PratyushJayachandran left review comments

@adamrusted adamrusted adamrusted approved these changes

@LitoMore LitoMore LitoMore left review comments

@dirien dirien dirien left review comments

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Odoo Icon
6 participants
@lucas-louis @adamrusted @LitoMore @PratyushJayachandran @dirien @sisp