Add TradingView icon #8809
Merged
Add TradingView icon #8809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
LitoMore
requested changes
Jun 20, 2023
There was a problem hiding this comment.
@bneeland I used https://tradingview.com/static/images/svg/tradingview-with-text-logo.svg as reference but found some differences.
Please make sure you're using the correct resource as reference.
PratyushJayachandran
requested changes
Jun 20, 2023
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
LitoMore
previously requested changes
Jun 29, 2023
There was a problem hiding this comment.
I use this one below as a reference:
<svg width="36" height="28" viewBox="0 0 36 28" xmlns="http://www.w3.org/2000/svg">
<path d="M14 22H7V11H0V4h14v18zM28 22h-8l7.5-18h8L28 22z" fill="currentColor"/>
<circle cx="20" cy="8" r="4" fill="currentColor"/>
</svg>But still found some differences:
PratyushJayachandran
previously requested changes
Jul 1, 2023
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
adamrusted
requested changes
Jul 18, 2023
There was a problem hiding this comment.
Even with @PratyushJayachandran's changes - I'm seeing major differences when compared to the SVG linked by @LitoMore. This'll still need some work I'm afraid!
PeterShaggyNoble
previously requested changes
Nov 20, 2023
|
In the interests of getting this merged in, I've taken another pass at this. This latest version is based on |
adamrusted
approved these changes
Nov 21, 2023
adamrusted
requested review from
PeterShaggyNoble
and removed request for
PeterShaggyNoble
adamrusted
dismissed stale reviews from PeterShaggyNoble, PratyushJayachandran, and LitoMore
Outdated
mondeja
added a commit
that referenced
this pull request
Nov 26, 2023
# New Icons - Alamy (#9717) - AlmaLinux (#9796) - avianca (#9899) - Basic Attention Token (#9725) - Bevy (#7076) - BitComet (#9563) - Blockbench (#8060) - BNB Chain (#9724) - Boosty (#8897) - Canvas (#9384) - CBC (#9881) - Celestron (#9898) - Chedraui (#9568) - Clerk (#9417) - Crew United (#9354) - Custom Ink (#9903) - Depositphotos (#9714) - Dreamstime (#9716) - Drizzle (#9606) - Expedia (#9912) - Fineco (#9495) - Google Cloud Spanner (#9472) - Google Dataflow (#9450) - Google Dataproc (#9451) - Google Pub/Sub (#9466) - Google Tasks (#9580) - GSMArena.com (#8276) - Headphone Zone (#9744) - JitPack (#7701) - Kick (#8910) - L'Équipe (#7857) - LibreOffice Base (#9595) - Loot Crate (#9875) - Mahindra (#9908) - Mailtrap (#8267) - Medusa (#8324) - Microsoft Store (#8802) - NHL (#9887) - Nordic Semiconductor (#9877) - NSIS (#7333) - Odoo (#6980) - openHAB (#8548) - OpenTofu (#9607) - OPPO (#9556) - Payhip (#8247) - Phosphor Icons (#9747) - Pi Network (#9890) - Pine Script (#9914) - Polestar (#9627) - Polygon (#9723) - PrepBytes (#9904) - Raycast (#8987) - Refine (#8842) - Rive (#9878) - RTM (#8066) - Sam's Club (#9577) - Session (#8246) - Slint (#9682) - StockX (#9889) - Toll (#8203) - TON (#8249) - TradingView (#8809) - Upptime (#9732) - VictoriaMetrics (#9479) - Vivint (#9882) - W3Schools (#9326) - WazirX (#9742) - WezTerm (#7774) - ZebPay (#9743) # Updated Icons - Appwrite (#9864) - B&R Automation (#9338) - C# (#9528) - Clubhouse (#9328) - Hyundai (#9653) - Proton Mail (#7793) - Proton VPN (#7795) # Removed Icons - (ISC)² (#9390) - Ableton Live (#9306) - Acclaim (#9301) - AddThis (#9371) - Anchor (#9302) - AngelList (#9303) - Angular Universal (#9832) - AngularJS (#9304) - Ask Ubuntu (#9294) - Atom (#9305) - Badgr (#9336) - Bath ASU (#9341) - BBC (#9870) - BBC iPlayer (#9870) - byte (#9337) - Code Review (#9294) - Deezer (#9856) - Forestry (#9108) - Hurriyetemlak (#9706) - Hyperledger (#9655) - Jenkins X (#9640) - JFrog Bintray (#9641) - LGTM (#9488) - MediaTemple (#9534) - Microsoft Office (#9896) - OpenTF (#9607) - Sendinblue (#9068) - SonarSource (#7801) - Sourcegraph (#9258) - TNT (#9838) - Twoo (#9509) - Untangle (#9459) - Uploaded (#9837) - W3C (#9885) - webhint (#9370) - WhiteSource (#9369) - Windi CSS (#9250) - Winmate (#9367) - Xilinx (#9190) - Yahoo! (#9861) - YOLO (#9836) - YourTravel.TV (#9182) - Z-Wave (#9180) - Zend Framework (#9133) - ZeroMQ (#9366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #8805
Similarweb rank:
284
https://www.similarweb.com/website/tradingview.com/#overview
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
Adds TradingView icon.