Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bevy Engine icon #7076

Merged
merged 9 commits into from Nov 22, 2023
Merged

Add Bevy Engine icon #7076

merged 9 commits into from Nov 22, 2023

Conversation

Weasy666
Copy link
Contributor

@Weasy666 Weasy666 commented Jan 19, 2022

bevy_simpleicons_webpage_grey

Alexa rank: 255,544
GitHub stars: 13,608

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Why did you pick the hex value?
I asked in the Bevy Discord and we settled on using the background color of the website.

Did you manually vectorize the logo?
Yes and no. I used an existing SVG file from the Bevy repository and modified it according to the contribution guide, incl. the optimization steps.

EDIT: Update icon with wider gaps.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jan 19, 2022
@Weasy666 Weasy666 force-pushed the bevy_engine branch 2 times, most recently from 693ddeb to a59cc04 Compare January 19, 2022 17:53
@Weasy666
Copy link
Contributor Author

Please don't merge, we noticed that the gaps of the icon are nearly invisible at the small scale used in the shields. We are evaluating to increase the gap and i will probably need to change the icon.

dirien
dirien previously requested changes Feb 22, 2022
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Weasy666,

thanks for the contribution. Unfortunatly there is a differenc in the eye region

image

{
"title": "Bevy",
"hex": "232326",
"source": "https://github.com/bevyengine/bevy/blob/main/assets/branding/bevy_bird_simpleicons.svg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you point here in the Bevy homepage only please. Thanks :)

@dirien
Copy link
Member

dirien commented Feb 22, 2022

Please don't merge, we noticed that the gaps of the icon are nearly invisible at the small scale used in the shields. We are evaluating to increase the gap and i will probably need to change the icon.

Ups, saw this reply too late and started to review! 😅

@sisp
Copy link
Contributor

sisp commented May 20, 2022

What's the state of this PR? Is it ready for review?

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the status is on this - but just compared PR against the Bevy repo, and found some differences.

_data/simple-icons.json Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the current version in this PR against the version in the bevy repo, I'm seeing the below differences. PR in black, repo in red.

image

Co-authored-by: Adam Rusted <hello@adamrusted.me>
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/bevy.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble marked this pull request as ready for review November 22, 2023 10:00
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
_data/simple-icons.json Outdated Show resolved Hide resolved
@adamrusted adamrusted removed the request for review from dirien November 22, 2023 15:13
@adamrusted adamrusted merged commit 3c73008 into simple-icons:develop Nov 22, 2023
4 checks passed
mondeja added a commit that referenced this pull request Nov 26, 2023
# New Icons

- Alamy (#9717)
- AlmaLinux (#9796)
- avianca (#9899)
- Basic Attention Token (#9725)
- Bevy (#7076)
- BitComet (#9563)
- Blockbench (#8060)
- BNB Chain (#9724)
- Boosty (#8897)
- Canvas (#9384)
- CBC (#9881)
- Celestron (#9898)
- Chedraui (#9568)
- Clerk (#9417)
- Crew United (#9354)
- Custom Ink (#9903)
- Depositphotos (#9714)
- Dreamstime (#9716)
- Drizzle (#9606)
- Expedia (#9912)
- Fineco (#9495)
- Google Cloud Spanner (#9472)
- Google Dataflow (#9450)
- Google Dataproc (#9451)
- Google Pub/Sub (#9466)
- Google Tasks (#9580)
- GSMArena.com (#8276)
- Headphone Zone (#9744)
- JitPack (#7701)
- Kick (#8910)
- L'&#201;quipe (#7857)
- LibreOffice Base (#9595)
- Loot Crate (#9875)
- Mahindra (#9908)
- Mailtrap (#8267)
- Medusa (#8324)
- Microsoft Store (#8802)
- NHL (#9887)
- Nordic Semiconductor (#9877)
- NSIS (#7333)
- Odoo (#6980)
- openHAB (#8548)
- OpenTofu (#9607)
- OPPO (#9556)
- Payhip (#8247)
- Phosphor Icons (#9747)
- Pi Network (#9890)
- Pine Script (#9914)
- Polestar (#9627)
- Polygon (#9723)
- PrepBytes (#9904)
- Raycast (#8987)
- Refine (#8842)
- Rive (#9878)
- RTM (#8066)
- Sam's Club (#9577)
- Session (#8246)
- Slint (#9682)
- StockX (#9889)
- Toll (#8203)
- TON (#8249)
- TradingView (#8809)
- Upptime (#9732)
- VictoriaMetrics (#9479)
- Vivint (#9882)
- W3Schools (#9326)
- WazirX (#9742)
- WezTerm (#7774)
- ZebPay (#9743)

# Updated Icons

- Appwrite (#9864)
- B&amp;R Automation (#9338)
- C# (#9528)
- Clubhouse (#9328)
- Hyundai (#9653)
- Proton Mail (#7793)
- Proton VPN (#7795)

# Removed Icons

- (ISC)&#178; (#9390)
- Ableton Live (#9306)
- Acclaim (#9301)
- AddThis (#9371)
- Anchor (#9302)
- AngelList (#9303)
- Angular Universal (#9832)
- AngularJS (#9304)
- Ask Ubuntu (#9294)
- Atom (#9305)
- Badgr (#9336)
- Bath ASU (#9341)
- BBC (#9870)
- BBC iPlayer (#9870)
- byte (#9337)
- Code Review (#9294)
- Deezer (#9856)
- Forestry (#9108)
- Hurriyetemlak (#9706)
- Hyperledger (#9655)
- Jenkins X (#9640)
- JFrog Bintray (#9641)
- LGTM (#9488)
- MediaTemple (#9534)
- Microsoft Office (#9896)
- OpenTF (#9607)
- Sendinblue (#9068)
- SonarSource (#7801)
- Sourcegraph (#9258)
- TNT (#9838)
- Twoo (#9509)
- Untangle (#9459)
- Uploaded (#9837)
- W3C (#9885)
- webhint (#9370)
- WhiteSource (#9369)
- Windi CSS (#9250)
- Winmate (#9367)
- Xilinx (#9190)
- Yahoo! (#9861)
- YOLO (#9836)
- YourTravel.TV (#9182)
- Z-Wave (#9180)
- Zend Framework (#9133)
- ZeroMQ (#9366)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants