Add Showwcase icon #8593
Add Showwcase icon #8593
Conversation
github-actions
bot
added
the
new icon
|
Can anyone help me with the errors? |
|
There were some error in .svg file, I've updated it. |
|
Hello @dushmanta05, the linter says the svg is not exactly 24px in one dimension (right now, it's 23.998 x 24.002). You should resize it in your editor to have a height (or whatever axis is larger) of exactly 24 while maintaining the aspect ratio (width should be around 23.996). Also, make sure you run it through SVGO so it's optimized and the linter won't complain about extraneous paths. |
|
@jwr12135 Hi, thank you again for helping me out. The svg code shows I've got 24 pixels (0 0 24 24) in the code editor, even in the GitHub file. I will use another editor and see if it works. And yes I had ran it through SVGO and kept the number precision to 3 as mentioned. Thanks. |
|
The viewbox is indeed set correctly, but the height of the |
Change order of attributes from "role, viewBox, height, xmlns" to "height, role, viewBox, xmlns".
|
Hello @jwr12135, I added the height to 24 pixels but got an error again. I added height as an attribute, and the error says height is an extra attribute. Can you please look into it? Thanks. |
Change height pixel to percentage
|
All simple icons SVG's use the following format: <svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>NAME HERE</title><path d="PATH DATA HERE"/></svg>So no extra height attributes are needed. Without getting into too much detail, the path data of an SVG is a list of all the points that make up the shape. The height I'm referring to is the distance between the highest point and the lowest point. To ensure this height (or distance) is exactly 24px, we can use an SVG editor to resize and move all the points on the path. In the following video, I show the steps needed to resize and center the SVG using Inkscape, but of course, any SVG editor should work. inkscape.mp4 |
Update SVG height to 24
Add 'role' and 'title', remove styles, change order of attribution
remove extraneous newline
Thank you for your help, that video saved the day, I'm just trying to remove the extraneous line through SVGO's tool now. Thank you again :) |
|
@jwr12135 I've tried few times with the online SVGO tool, but it's always showing "extraneous Unexpected newline character(s) detected", got to try few more times. |
|
Glad the video helped ❤️. Your best bet for removing the new line would be to remove it through a text editor manually. The built-in GitHub text editor might also let you do that. |
|
@jwr12135 Well, I've used SVGO tool and looking at this code, I don't think there are any newline characters but it's still failing! |
Co-authored-by: Adam Rusted <hello@adamrusted.me>
|
@PeterShaggyNoble I've updated it. Also, thank you, @adamrusted, for the suggestion :) |
There was a problem hiding this comment.
Thanks for taking another look at this @dushmanta05!
It looks like the icon is still stretched to fill the 24*24 viewport, as opposed to only being 24px in it's widest dimension. According to Affinity Designer, it should be 24*21.6 - but centered on the 24*24 canvas.
adamrusted
removed
awaiting reply
|
Thanks for the review, and I'm working on the logo stretched part, @adamrusted. I'll update you with further changes. |
|
Here's my attempt at it, @dushmanta05, if it's any help. Oh, how I wanted to take liberties with this one and clean up all the imperfections! |
|
@PeterShaggyNoble Thanks for the suggestion, I will check this and let you know :) |
PeterShaggyNoble
requested review from
adamrusted,
service-paradis and
PratyushJayachandran
and removed request for
jwr1
# New Icons - Airtel (#9709) - Biome (#10110) - Charles (#9906) - Clever Cloud (#10083) - Code::Blocks (#7335) - ComicFury (#10013) - daily.dev (#10058) - date-fns (#10093) - DBeaver (#8218) - Embark (#10124) - ERPNext (#9245) - Frappe (#9245) - GitHub Copilot (#9500) - Goldman Sachs (#9910) - Google Bigtable (#9439) - Greasy Fork (#10095) - Helium (#10049) - KX (#10051) - LibreOffice Calc (#9923) - LinuxServer (#9616) - Logitech G (#10063) - Metacritic (#10078) - NetEase Cloud Music (#10062) - OSF (#7700) - pipx (#10072) - Proteus (#8793) - Qase (#9907) - Red Bull (#6016) - Runrun.it (#10103) - Semantic UI (#10029) - Showwcase (#8593) - SimpleLogin (#10041) - SRG SSR (#10037) - Télé-Québec (#10076) - THE FINALS (#10125) - The Odin Project (#9161) - Thunderstore (#10025) - Tindie (#9996) - TrillerTV (#10097, #10112) - Uniqlo (#10102) - Uniqlo (#9754) - Virgin Atlantic (#10064) - Wondershare (#10117) # Updated Icons - Android (#10085) - Bugatti (#10099) - Channel 4 (#10100) - Citroën (#10101) - Citroën (#10101) - Counter-Strike (#10106) - Cypress (#10070) - Dolby (#10107) - Facebook (#10069) - Glassdoor (#10071) - IVECO (#10068) - Kinopoisk (#10084) - LibreOffice Base (#10059) - NBC (#10067) - Riot Games (#10105) - Slides (#10089)
|
@PeterShaggyNoble Thank you so much for your effort and time, glad that you fixed the icon. |
Issue: closes #6950
Similarweb rank: 278,711
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description