Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Copilot #9500

Merged
merged 10 commits into from Dec 11, 2023
Merged

Conversation

DenverCoder1
Copy link
Contributor

@DenverCoder1 DenverCoder1 commented Sep 6, 2023

image

Issue: closes #9499

Similarweb rank: 80

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Note: there are two variations of the GitHub Copilot logo:

SVG v1: primer.style/design/foundations/icons/copilot-16
SVG v2: primer.style/design/foundations/icons/copilot-24

The 24x24 was the original icon in this PR, but I changed it to the 16x16 variation based on feedback from @LitoMore at #9499 (comment).

  • The hex value is from the listing in the VS Code extensions marketplace
    image
  • The 16x16 icon was taken from GitHub's Octicons library (MIT License). I manually centered the icon vertically and unioned the paths and set the size to 24x24.
Alternative variation (not in this PR)

image

  • The 24x24 icon was taken from GitHub's Octicons library (MIT License). I manually centered the icon vertically and unioned the paths.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 6, 2023
@DenverCoder1 DenverCoder1 mentioned this pull request Sep 6, 2023
@adamrusted adamrusted added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Sep 7, 2023
@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 1, 2023
@PeterShaggyNoble PeterShaggyNoble changed the title New Icon: GitHub Copilot Add GitHub Copilot Dec 1, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a few tiny differences throughout, such as this one in both eyes (your version in red), which can likely be fixed by upping the precision.

@DenverCoder1
Copy link
Contributor Author

DenverCoder1 commented Dec 9, 2023

I downloaded the icon from https://primer.style/foundations/icons/copilot-24, unioned the paths and used the center align tool in Inkscape, and optimized with https://jakearchibald.github.io/svgomg/ (number precision set to 3)

@DenverCoder1 DenverCoder1 marked this pull request as draft December 9, 2023 16:54
@DenverCoder1 DenverCoder1 force-pushed the github-copilot branch 2 times, most recently from 1f7acc4 to 0da0c43 Compare December 9, 2023 16:57
@DenverCoder1 DenverCoder1 marked this pull request as ready for review December 9, 2023 17:00
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, @DenverCoder1, it turns out the differences I was seeing were a result of the source icon not being centrally aligned along the horizontal axis 🤦🏻‍♂️ After fixing that, the previous version lined up perfectly.

icons/githubcopilot.svg Outdated Show resolved Hide resolved
@PeterShaggyNoble PeterShaggyNoble merged commit 268610f into simple-icons:develop Dec 11, 2023
3 checks passed
mondeja added a commit that referenced this pull request Dec 17, 2023
# New Icons

- Airtel (#9709)
- Biome (#10110)
- Charles (#9906)
- Clever Cloud (#10083)
- Code::Blocks (#7335)
- ComicFury (#10013)
- daily.dev (#10058)
- date-fns (#10093)
- DBeaver (#8218)
- Embark (#10124)
- ERPNext (#9245)
- Frappe (#9245)
- GitHub Copilot (#9500)
- Goldman Sachs (#9910)
- Google Bigtable (#9439)
- Greasy Fork (#10095)
- Helium (#10049)
- KX (#10051)
- LibreOffice Calc (#9923)
- LinuxServer (#9616)
- Logitech G (#10063)
- Metacritic (#10078)
- NetEase Cloud Music (#10062)
- OSF (#7700)
- pipx (#10072)
- Proteus (#8793)
- Qase (#9907)
- Red Bull (#6016)
- Runrun.it (#10103)
- Semantic UI (#10029)
- Showwcase (#8593)
- SimpleLogin (#10041)
- SRG SSR (#10037)
- Télé-Québec (#10076)
- THE FINALS (#10125)
- The Odin Project (#9161)
- Thunderstore (#10025)
- Tindie (#9996)
- TrillerTV (#10097, #10112)
- Uniqlo (#10102)
- Uniqlo (#9754)
- Virgin Atlantic (#10064)
- Wondershare (#10117)

# Updated Icons

- Android (#10085)
- Bugatti (#10099)
- Channel 4 (#10100)
- Citroën (#10101)
- Citroën (#10101)
- Counter-Strike (#10106)
- Cypress (#10070)
- Dolby (#10107)
- Facebook (#10069)
- Glassdoor (#10071)
- IVECO (#10068)
- Kinopoisk (#10084)
- LibreOffice Base (#10059)
- NBC (#10067)
- Riot Games (#10105)
- Slides (#10089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Copilot
3 participants