Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google bigtable #9439

Merged

Conversation

PratyushJayachandran
Copy link
Member

@PratyushJayachandran PratyushJayachandran commented Aug 29, 2023

googlebigtable

Issue: closes #5133

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from https://cloud.google.com/icons
Color: Taken from logo #669df6

Note
The source itself has misaligned objects in the icon

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Aug 29, 2023
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PratyushJayachandran,

thanks for your contribution to Simple Icons.

Can you check on the "spikes" of the icon? See picture below for what I mean. There are some small differences to the original.

image

@PratyushJayachandran
Copy link
Member Author

Hi @PratyushJayachandran,

thanks for your contribution to Simple Icons.

Can you check on the "spikes" of the icon? See picture below for what I mean. There are some small differences to the original.

I'll increase the precision. The spikes are there in original too

@PratyushJayachandran
Copy link
Member Author

Hi @PratyushJayachandran,

thanks for your contribution to Simple Icons.

Can you check on the "spikes" of the icon? See picture below for what I mean. There are some small differences to the original.

image

I have fixed it by increasing the precision to 4. Can you check it again.

@adamrusted adamrusted mentioned this pull request Sep 3, 2023
9 tasks
@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Nov 24, 2023

Jebus, that source icon is horrendous! 😮 Even just combining all the paths into one starts introducing some minor differences.

Given how riddled with imperfections the original is, I'd be OK in this instance with running with our best effort even if it's not a perfect match. What do you think, @dirien? Or we take some artistic license and clean it up completely.

@PratyushJayachandran
Copy link
Member Author

Jebus, that source icon is horrendous! 😮 Even just combing all the paths into one starts introducing some minor differences.

Given how riddled with imperfections the original is, I'd be OK in this instance with running with our best effort even if it's not a perfect match. What do you think, @dirien? Or we take some artistic license and clean it up completely.

So I spent some time to clean up the source. Attaching it here:
bigtable-cleaned-up

I redid with this as source. Please review again 😢

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your cleaned up version looks good to me, @PratyushJayachandran, I'm happy to run with it as-is given the state of the original. As we are taking a little artistic license, though, we'll need approval from one other member of the team before merging.

For consistency with other icons from this collection, though, should we not either go with Google blue or #AECBFA for the colour?

@PratyushJayachandran
Copy link
Member Author

Your cleaned up version looks good to me, @PratyushJayachandran, I'm happy to run with it as-is given the state of the original. As we are taking a little artistic license, though, we'll need approval from one other member of the team before merging.

For consistency with other icons from this collection, though, should we not either go with Google blue or #AECBFA for the colour?

I'm fine with either.

Your cleaned up version looks good to me, @PratyushJayachandran, I'm happy to run with it as-is given the state of the original. As we are taking a little artistic license, though, we'll need approval from one other member of the team before merging.

For consistency with other icons from this collection, though, should we not either go with Google blue or #AECBFA for the colour?

I'm fine if the color needs to be changed. I always picked color from the dominant color on the logo.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the hex as is. Also happy with the treatment given by @PratyushJayachandran to the icon. Unfortunately I can't download the source from your comment, it's giving me a 404. Given @PeterShaggyNoble has already approved the path though, I'm good to just run with it.

@PeterShaggyNoble PeterShaggyNoble merged commit 125e09a into simple-icons:develop Dec 15, 2023
3 checks passed
mondeja added a commit that referenced this pull request Dec 17, 2023
# New Icons

- Airtel (#9709)
- Biome (#10110)
- Charles (#9906)
- Clever Cloud (#10083)
- Code::Blocks (#7335)
- ComicFury (#10013)
- daily.dev (#10058)
- date-fns (#10093)
- DBeaver (#8218)
- Embark (#10124)
- ERPNext (#9245)
- Frappe (#9245)
- GitHub Copilot (#9500)
- Goldman Sachs (#9910)
- Google Bigtable (#9439)
- Greasy Fork (#10095)
- Helium (#10049)
- KX (#10051)
- LibreOffice Calc (#9923)
- LinuxServer (#9616)
- Logitech G (#10063)
- Metacritic (#10078)
- NetEase Cloud Music (#10062)
- OSF (#7700)
- pipx (#10072)
- Proteus (#8793)
- Qase (#9907)
- Red Bull (#6016)
- Runrun.it (#10103)
- Semantic UI (#10029)
- Showwcase (#8593)
- SimpleLogin (#10041)
- SRG SSR (#10037)
- Télé-Québec (#10076)
- THE FINALS (#10125)
- The Odin Project (#9161)
- Thunderstore (#10025)
- Tindie (#9996)
- TrillerTV (#10097, #10112)
- Uniqlo (#10102)
- Uniqlo (#9754)
- Virgin Atlantic (#10064)
- Wondershare (#10117)

# Updated Icons

- Android (#10085)
- Bugatti (#10099)
- Channel 4 (#10100)
- Citroën (#10101)
- Citroën (#10101)
- Counter-Strike (#10106)
- Cypress (#10070)
- Dolby (#10107)
- Facebook (#10069)
- Glassdoor (#10071)
- IVECO (#10068)
- Kinopoisk (#10084)
- LibreOffice Base (#10059)
- NBC (#10067)
- Riot Games (#10105)
- Slides (#10089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google cloud services
4 participants