Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more efficient sync indexes #1900

Merged
merged 3 commits into from
Dec 23, 2020
Merged

Add more efficient sync indexes #1900

merged 3 commits into from
Dec 23, 2020

Conversation

kitallis
Copy link
Contributor

@kitallis kitallis commented Dec 18, 2020 •
edited by prabhanshuguptagit
Loading

Story card: ch2086

Because

Simply having an updated_at index is in fact slower than not having it, across different access patterns for our app.

This addresses

A better index is a composite index on patient_id and updated_at that is overall faster. More info on it here.

@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1900 December 18, 2020 06:19 Inactive
@kitallis kitallis mentioned this pull request Dec 18, 2020
Merged
@kitallis kitallis changed the title Add faster sync indexes Add more efficient sync indexes Dec 18, 2020
@prabhanshuguptagit prabhanshuguptagit mentioned this pull request Dec 18, 2020
Open
@prabhanshuguptagit prabhanshuguptagit marked this pull request as ready for review December 18, 2020 15:26
harimohanraj89
harimohanraj89 approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@harimohanraj89 harimohanraj89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What about Encounters? I see they are a sync resource in our API.

@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1900 December 22, 2020 14:33 Inactive
@prabhanshuguptagit prabhanshuguptagit temporarily deployed to simple-review-pr-1900 December 22, 2020 14:39 Inactive
@prabhanshuguptagit prabhanshuguptagit merged commit 81e8b01 into master Dec 23, 2020
@prabhanshuguptagit prabhanshuguptagit deleted the add-better-sync-indexes branch December 23, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harimohanraj89 harimohanraj89 harimohanraj89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kitallis @harimohanraj89 @prabhanshuguptagit