Implement namespaces and PSR2 compliance #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #53 Any feedback on the last 3 commits @thijskh, @relaxnow or @jaimeperez? If not I'll merge this tomorrow morning (CET), create the release 2.x branch and tag release 2.0.0 |
|
No objections from me! |
|
Didn't have time to look at it carefully, but it should be ok, so 👍 from me too. |
|
👍 |
DRvanR
added a commit
that referenced
this pull request
Dec 22, 2015
Implement namespaces and PSR2 compliance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the awesome work of @cb8 in #53
master, conflicts have been resolved, new code has been adapted