Mymaster #35
Merged
Mymaster #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Manfred, Any comments on these commits? |
|
I had a quick merge attempt of the other pull requests.. and just a very quick glance here. It looks good but I can not automatically merge it in github. Could you rebase it off master so I can do that. I am hoping to pull this in and test it and then release 3.0.0 this week. I am sick of RCs.. |
added 4 commits
March 4, 2013 19:23
Trivial implementations of the getHost(), getPort(), and getPath() methods moved to base class. Throws declarations added to these methods.
1. According to Javadoc and Droidoc 'each HttpURLConnection instance is used to make a single request' only. Any attempt to change HttpURLConnection properties or request data after request is made will raise either IllegalStateException or ProtocolException. So it is no sense to keep ServiceConnection instance inside HttpTransport related classes. 2. Keeping ServiceConnection instance inside HttpTransport class prevents this HttpTransport object from reusing. It is good idea to remove ServiceConnection field from HttpTransport related classes.
|
Please try it again. I have made rebase. |
|
Sweet... its in master. I will test this tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, make a review for proposed commits (especially last one)