-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow TestCase init with list of examples #40
Conversation
Unittest integration: Allow TestCase init with list of examples.
The CI failure is telling you that line 20 of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid I really don't like this. Let's keep discussing on #40 and see what we can come up with.
@@ -6,3 +6,5 @@ | |||
_build/ | |||
.*cache/ | |||
pytestdebug.log | |||
*.pyc | |||
pyvenv.cfg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These belong in your personal config, not in the project config, since they're tool specific things. Ignoring .pycs is, pragmatically, a global thing belong in your global or per-user git config rather than a project one.
---------- | ||
|
||
- Unittest integration: Allow TestCase init with list of examples. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't bother with change log entries when doing a PR, I collate those when doing a release.
assert results.total == 8 | ||
assert results.failures == 1 | ||
assert results.total == 10 | ||
assert results.failures == 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why have these changed?
See issue for my intent for this suggestion.