Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TestCase init with list of examples #40

Closed
wants to merge 6 commits into from

Conversation

ksuess
Copy link

@ksuess ksuess commented Apr 19, 2022

See issue for my intent for this suggestion.

@cjw296
Copy link
Member

cjw296 commented Apr 19, 2022

The CI failure is telling you that line 20 of test_unittest_listofexamples.py is never executed.

Copy link
Member

@cjw296 cjw296 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I really don't like this. Let's keep discussing on #40 and see what we can come up with.

@@ -6,3 +6,5 @@
_build/
.*cache/
pytestdebug.log
*.pyc
pyvenv.cfg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These belong in your personal config, not in the project config, since they're tool specific things. Ignoring .pycs is, pragmatically, a global thing belong in your global or per-user git config rather than a project one.

----------

- Unittest integration: Allow TestCase init with list of examples.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't bother with change log entries when doing a PR, I collate those when doing a release.

assert results.total == 8
assert results.failures == 1
assert results.total == 10
assert results.failures == 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have these changed?

@cjw296 cjw296 closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants