Add tests for single-document population transforms

Signed-off-by: Ian Macalinao <me@ian.pw>
macalinao · Aug 12, 2014 · 025de86 · 025de86
1 parent 5a0d62a
commit 025de86
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 0 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -179,8 +179,10 @@ Model.prototype.transformPopulate = function(field, transformer) {
     }
 
     // Normalize
+    var single = false;
     if (typeof pop === 'object' && !Array.isArray(pop)) {
       pop = [pop];
+      single = true;
     }
 
     // Ensure array, as it isn't an object at this point
@@ -208,6 +210,9 @@ Model.prototype.transformPopulate = function(field, transformer) {
         return done(err, subDoc);
       });
     }, function(err, result) {
+      if (single) {
+        result = result[0];
+      }
       doc[field] = result;
       next();
     });

diff --git a/test/model.js b/test/model.js
@@ -63,6 +63,41 @@ describe('Model', function() {
       });
     });
 
+    it('should synchronously populate-transform a document', function(done) {
+      User.transformPopulate('spouse', function(req, doc) {
+        doc.name = 'Tim';
+      });
+      User.applyTransforms(null, {
+        toObject: function() {
+          return {
+            spouse: {}
+          };
+        }
+      }, function(err, doc) {
+        expect(doc.spouse.name).to.equal('Tim');
+        done();
+      });
+    });
+
+    it('should asynchronously populate-transform a document', function(done) {
+      User.transformPopulate('spouse', function(req, doc, next) {
+        async.times(1, function() {
+          doc.name = 'Tim';
+          next();
+        });
+      });
+      User.applyTransforms(null, {
+        toObject: function() {
+          return {
+            spouse: {}
+          };
+        }
+      }, function(err, doc) {
+        expect(doc.spouse.name).to.equal('Tim');
+        done();
+      });
+    });
+
     it('should synchronously populate-transform a document array', function(done) {
       User.transformPopulate('friends', function(req, doc) {
         doc.name = 'Tim';
@@ -98,5 +133,19 @@ describe('Model', function() {
       });
     });
 
+    it('should not transform a non-existent field', function(done) {
+      User.transformPopulate('dne', function(req, doc) {
+        doc.asdf = 'asdf';
+      });
+      User.applyTransforms(null, {
+        toObject: function() {
+          return {};
+        }
+      }, function(err, doc) {
+        expect(doc.asdf).to.be.undefined;
+        done();
+      });
+    });
+
   });
 });