Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from std::regex to re2 #105

Merged
merged 18 commits into from
Jan 17, 2024
Merged

switch from std::regex to re2 #105

merged 18 commits into from
Jan 17, 2024

Conversation

simsong
Copy link
Owner

@simsong simsong commented Jan 16, 2024

No description provided.

@simsong simsong self-assigned this Jan 16, 2024
@simsong simsong marked this pull request as ready for review January 16, 2024 18:04
@simsong
New3 (#109)
cdc4676 
* New2 (#107)

* autoconf now checks for re2

* now works with RE2. Now we need to redo the tests

* made configure more verbose

* added re2 abseil pkg-config to brew install

* make it explicit
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ef262e5) 61.69% compared to head (b8926c9) 61.87%.
Report is 4 commits behind head on main.

Files Patch % Lines
regex_vector.h 87.50% 2 Missing ⚠️
regex_vector.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   61.69%   61.87%   +0.19%     
==========================================
  Files          45       45              
  Lines        2665     2678      +13     
==========================================
+ Hits         1644     1657      +13     
  Misses       1021     1021

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simsong simsong merged commit c2d082d into main Jan 17, 2024
2 checks passed
@simsong simsong deleted the new-regex branch January 17, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simsong simsong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simsong