[Action] split parsed time values into pct multipliers and flat modifiers #8946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flat addition/subtraction modifiers to execute time are applied before percentage multiplication via various effects. As many of these effects are automatically parsed from the spell data, we need to keep track of these two types separately and reconstitute them at the final call of execute_time() in order to preserve the order of operations.
* [Outlaw] Killing Spree has higher prio than Vanish * [Outlaw] KS no longer needed in finish action list * [Outlaw] Stricter Thistle Tea usage
Celestial Brew Purified Chi Notes on the temporary make_buff_fallback fix. Press the Advantage Rising Sun Kick Press the Advantage Keg Smash Light Brewing Bob and Weave Convert TP to autoparsing effects Pretense of Instability Black Ox Adept Heightened Guard Strike at Dawn
gastank
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flat addition/subtraction modifiers to execute time, tick time, and dot duration are applied before percentage multiplication via various effects. As these effects are often automatically parsed from the spell data, we need to keep track of these two types separately and reconstitute them at the final call of execute_time()/tick_time()/composite_dot_duration() in order to preserve the order of operations.