Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically trim / from url, rm main.go from .gitignore #102

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Automatically trim / from url, rm main.go from .gitignore #102

merged 2 commits into from
Dec 15, 2023

Conversation

erkexzcx
Copy link
Contributor

This PR fixes this issue:

$ ./immich-go -server 'https://example.com/' -key xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx upload -google-photos /path/to/export/*.zip
immich-go  0.9.1, commit eb5078844270bab6e076931e8bec9b6fd070d725, built at 2023-12-13T17:58:58Z

PingServer, GET, https://example.com//api/server-info/ping, 200 OK
invalid character '<' looking for beginning of value
invalid character '<' looking for beginning of value

While 'https://example.com/' is giving above error, 'https://example.com' is working fine.

Currently, there is no error handling, but we don't need to - it's fine to automatically remove / from the end of -server value if it exists.

Also I've removed main.go from .gitignore as I assume it was added by accident? This fixes my recently raised #101.

@simulot
Copy link
Owner

simulot commented Dec 15, 2023

Thanks for this PR

@simulot simulot merged commit 0e729db into simulot:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants