Feat/conversation conversations #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add stop, update,delete implementations
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
asein-sinch
reviewed
Jan 31, 2024
asein-sinch
reviewed
Jan 31, 2024
| var propMask = conversation.GetPropertiesMask(); | ||
| if (!string.IsNullOrEmpty(propMask)) queryString.Add("update_mask", propMask); | ||
|
|
||
| if (metadataUpdateStrategy is not null) |
There was a problem hiding this comment.
This query parameter should have a default value set to REPLACE
There was a problem hiding this comment.
Isn't it optional and going to be defaulted by the server?
There was a problem hiding this comment.
I don't know how to verify that. I hope that this information is intended to the server teams but in order to be on the safe side we may send the default value if nothing is specified by the user
asein-sinch
reviewed
Jan 31, 2024
asein-sinch
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers Conversations/Conversation tag of api.
Also, includes rework of Conversation/Messages models to match server json schema