Feat/fax api faxes #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Volodymyr Lisovskyi <erehonvl@gmail.com>
Co-authored-by: Volodymyr Lisovskyi <erehonvl@gmail.com>
Co-authored-by: Volodymyr Lisovskyi <erehonvl@gmail.com>
Co-authored-by: Volodymyr Lisovskyi <erehonvl@gmail.com>
…ime` property in the `Fax.cs` file, the addition of a new `Download` method in the `Faxes.cs` file, and the update of package versions in the `Sinch.csproj` file. 1. The `CreateTime` property in the `Fax.cs` file under the `Sinch.Faxes` namespace has been altered. Previously, it was a string type, but it has now been changed to a DateTime type. This change will ensure that the `CreateTime` property holds date and time information in a more structured and accurate manner. 2. A new asynchronous method named `Download` has been added to the `Faxes.cs` file under the `Sinch.Faxes` namespace. This method accepts an id as a parameter and returns a Stream. This addition will allow users to download fax data asynchronously using the provided id. 3. The versions of the `Microsoft.Extensions.Http` and `System.Text.Json` packages in the `Sinch.csproj` file have been updated. The `Microsoft.Extensions.Http` package has been updated from version 7.0.0 to 8.0.0, and the `System.Text.Json` package has been updated from version 7.0.3 to 8.0.2. These updates will ensure that the project uses the latest and most secure versions of these packages. References: - `Fax.cs` file under the `Sinch.Faxes` namespace for the `CreateTime` property change. - `Faxes.cs` file under the `Sinch.Faxes` namespace for the new `Download` method. - `Sinch.csproj` file for the package version updates.
asein-sinch
reviewed
May 21, 2024
Dovchik
commented
May 21, 2024
There was a problem hiding this comment.
Thanks for the review Antoine! Here you will find adjustment to mocks https://github.com/sinch/doppelganger/pull/25
asein-sinch
reviewed
May 21, 2024
asein-sinch
reviewed
May 21, 2024
asein-sinch
reviewed
May 21, 2024
|
Added an override for send fax https://github.com/sinch/doppelganger/pull/26 |
asein-sinch
reviewed
May 22, 2024
asein-sinch
approved these changes
May 22, 2024
There was a problem hiding this comment.
Well done. Regarding the PR organization, maybe you can create another branch from main where all the sub-features for Fax (this PR being one of the sub-features) will be merged. Otherwise, I fear it will be a mess if you need to come back to the Faxes part once Email will be merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce Fax Api support
This PR brings in FaxClient interface and implementation of Faxes tag.
This is a PR sink for other fax related PRs as well.
Will be merged only when other child PRs regarding other tags will be merge into current.