-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(voice): refs? #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable-ref-types-voice
Dovchik
changed the base branch from
feat/enable-nullable-reference-types
to
main
April 19, 2024 08:47
…m/sinch/sinch-sdk-net-proto into refactor/nullable-ref-types-voice
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
April 19, 2024 10:50
asein-sinch
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review done. I checked the parts related to Conversation and SMS too, even if the PR mentioned voice only
asein-sinch
approved these changes
Apr 23, 2024
* refactor(verification): refs?
* refactor(sms): refs?
* refactor(numbers): refs?
* refactor(conversation): refs? * fix: analyzer warns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For models any non-required/optional field is nullable
Add EmptyResponse class for empty responses from the API, refactor api calls to use it