feat(example): add handling of incoming call event #56
Conversation
Dovchik
requested review from
650elx,
krogers0607,
asein-sinch and
JPPortier
as code owners
examples/WebApi/Controllers/HandleIncomingIceEventController.cs
Outdated
Show resolved
Hide resolved
|
Added refactor for events to have generic interface which can be used for pattern matching |
| [Route("event")] | ||
| public IActionResult HandleEvent([FromBody] IVoiceEvent incomingEvent) | ||
| { | ||
| switch (incomingEvent) |
There was a problem hiding this comment.
Ideally Voice should provide a ValidateAuthenticationHeader function (like Conversation domains: https://github.com/sinch/sinch-sdk-dotnet/blob/main/src/Sinch/Conversation/Webhooks/Webhooks.cs#L72)
Calling ValidateAuthenticationHeader here and because this sample is a tutorial, it will help to highlight endpoint is having to be "protected" against unsolicited requests
There was a problem hiding this comment.
Makes sense, blocked by #62
| } | ||
| } | ||
| }; | ||
| return Ok(response); |
There was a problem hiding this comment.
Side note: like the OK/BadRequest; need to think about having same "helper" for Java SDK to hide/help the response serialization requirements
| @@ -64,5 +63,7 @@ public class AnsweredCallEvent | |||
| /// </summary> | |||
| [JsonPropertyName("amd")] | |||
| public Amd? Amd { get; set; } | |||
|
|
|||
| public EventType? EventType { get; } | |||
There was a problem hiding this comment.
Seems this field is not present from specs. Could be removed?
There was a problem hiding this comment.
There was a problem hiding this comment.
🤯 I was sure I fixed that, I'll open PR with a fix soon
No description provided.