Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After macOS waking up without internet connection, no website is shown #41

Open
muuvmuuv opened this issue Feb 4, 2020 · 2 comments
Open
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@muuvmuuv
Copy link

muuvmuuv commented Feb 4, 2020

Describe the bug

I'm working on different setups where one has internet through WLAN and the other over LAN. When switching workplaces (opening/closing the lid) it seems Plash can not reload the web page or get back to the last state.

To reproduce

Steps to reproduce the behavior:

  1. Open any website
  2. Turn off w-lan
  3. Close the lid
  4. Open the lid
  5. red Plash icon
  6. no website

Expected behavior

Saving the last state and waiting for a new internet connection or use a service worker to save the site offline.

Screenshots

If applicable, add screenshots to help explain your problem.

Info

  • macOS version: 10.15.2
  • Plash version: latest (don't know where I can see this, mabye add the version and hash as read only menu item)

Additional context

Add any other context about the problem here.

@muuvmuuv muuvmuuv added the bug Something isn't working label Feb 4, 2020
sindresorhus added a commit that referenced this issue Feb 6, 2020
@sindresorhus
Copy link
Owner

I added a quick workaround for this in 42ae54e. Now it won't reload if there's no internet connection. However, it will not automatically reload when you regain the connection, unless you have a "reload interval" preference set.

Note to self or anyone that wants to work on this:

The proper fix is to create a new web view below the existing one (with no opacity), load the URL, if it succeeds, we fade out the old one while fading in the new one. If it fails, we discard the new web view. We should also listen to when the connection is regain and then reload.

@sindresorhus sindresorhus added the help wanted Extra attention is needed label Feb 6, 2020
@sindresorhus
Copy link
Owner

don't know where I can see this, mabye add the version and hash as read only menu item

Plash menu => More => About

sindresorhus added a commit that referenced this issue Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants