-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show stderr in the debugger #112
Conversation
test/test.js
Outdated
@@ -11,17 +10,6 @@ test('default', t => { | |||
t.is(typeof alfyInstance.icon.error, 'string'); | |||
}); | |||
|
|||
test.serial('.error()', async t => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing the test? We still want to test .error()
.
Bump |
Oh sorry, I missed this notification. I forgot why I removed this test. Let me check it. |
This reverts commit f3433c3.
Now I'm facing another bug. It seems Script Filter has the length limitation. For example: alfy.output([{
title: 'e'.repeat(1000),
subtitle: 'Press ⌘L to see the full error and ⌘C to copy it.',
valid: false,
text: {
copy: 'copy',
largetype: 'stack'
},
icon: {
path: exports.icon.error
}
}]); It will throw a JSON error like this:
We put too much letters to Should I do the simplify work in this pull request? |
Sure, what's the max length? |
@sindresorhus The max length is 65532 (Alfred 4.0.6 [1124]). |
Truncate the |
Not only the title, |
|
Ok, I now realize we're talking about different things. I was talking about the error specifically. You're talking about it generally.
|
Bump |
@LitoMore Bump |
Roger. I will follow up on the weekend. |
Bump |
Resolve #86
IssueHunt Summary
Referenced issues
This pull request has been submitted to:
IssueHunt has been backed by the following sponsors. Become a sponsor