Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icons #1501

Merged
merged 2 commits into from May 17, 2019
Merged

Add Icons #1501

merged 2 commits into from May 17, 2019

Conversation

notlmn
Copy link
Contributor

@notlmn notlmn commented Jan 15, 2019

https://github.com/notlmn/awesome-icons

I've been into web development for 5 years, but the number of icon projects that people know are very limited (like FontAwesome, Material Design, and maybe Octicons).

This list provides a list of awesome enough icon projects that are awesome enough, hosted mostly on GitHub.


By submitting this pull request I confirm I've read and complied with the requirements mentioned in PR template, except for

  • having a more detailed explanation in the readme, I think the list is enough descriptive
  • having a contribution.md file (fixed)

@simskij
Copy link
Contributor

simskij commented Jan 16, 2019

Thanks for submitting!
Nice collection and great work.

  • Please include the PRs you've reviewed in your merge request.
  • Add the contribution.md as it's stated as a requirement. Openly stating that you've skipped it is not enough.
  • Feel free to add Font Awesomes paid alternatives under Other > Paid.

@notlmn
Copy link
Contributor Author

notlmn commented Jan 29, 2019

Updated the repo with contribution guidelines and CoC, also setup to automatically lint using awesome-lint.

@sindresorhus
Copy link
Owner

This pull request has a descriptive title in the format Add Name of List (Example: Add Swift), not Update readme.md or Add awesome list.

@sindresorhus
Copy link
Owner

Be added at the bottom of the appropriate category.

@sindresorhus
Copy link
Owner

Includes a project logo/illustration whenever possible.

Your list is about icons. Makes sense to have an actual icon graphic in it.

@sindresorhus
Copy link
Owner

downloadable SVG/PNG/Font icon projects => downloadable SVG/PNG/font icon projects

@notlmn notlmn changed the title Mention awesome-icons list Add awesome-icons Feb 26, 2019
@notlmn
Copy link
Contributor Author

notlmn commented May 15, 2019

I've added a graphic that is somewhat closely related to icons.

Please review again.

@sindresorhus sindresorhus changed the title Add awesome-icons Add Icons May 16, 2019
@sindresorhus
Copy link
Owner

downloadable SVG/PNG/Font icon projects => downloadable SVG/PNG/font icon projects

This was not done in your readme.

@sindresorhus
Copy link
Owner

One tag One icon, no font or svg, pure CSS.

I know you didn't write the descriptions, but it's expected that you ensure the descriptions are of high quality too. Please go through each description and improve them.

@sindresorhus
Copy link
Owner

The section descriptions should also end in a ..

@notlmn
Copy link
Contributor Author

notlmn commented May 17, 2019

downloadable SVG/PNG/Font icon projects => downloadable SVG/PNG/font icon projects

This was not done in your readme.

Oh, I only changed that in the readme and not in the repo description. Done now.


The section descriptions should also end in a ..

Done.


One tag One icon, no font or svg, pure CSS.

I know you didn't write the descriptions, but it's expected that you ensure the descriptions are of high quality too. Please go through each description and improve them.

I didn't mean to change them from what the original author intended them to be, so left them as is. Changed this one though.

@sindresorhus
Copy link
Owner

sindresorhus commented May 17, 2019

I didn't mean to change them from what the original author intended them to be, so left them as is.

You should, if you can do it better. From experience, most authors have no idea how to write good descriptions. For example, in Awesome Node.js I have pretty much rewritten the description for every entry.

@sindresorhus sindresorhus merged commit ce108dc into sindresorhus:master May 17, 2019
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1129292915191140352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants