-
-
Notifications
You must be signed in to change notification settings - Fork 27.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Ember #1579
Update Ember #1579
Conversation
Please read https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md and make sure the list passes https://github.com/sindresorhus/awesome-lint |
@lifeart, It seems very useful its update. Make a pull request! Just a preview of the awesome-lint https://github.com/ember-community-russia/awesome-ember
...
298 errors Common errors:
|
One of the other things I noticed is no contributing guidelines. You link to one though from the readme: https://github.com/ember-community-russia/awesome-ember/blob/master/contributing.md |
You have not read it fully. |
unicorn |
@lifeart |
|
Not done https://github.com/ember-community-russia/awesome-ember/blob/master/contributing.md should be customized for your list and not just copy-pasted. The repo description needs to be improved.
Not done The item descriptions should not be in title case. Many of the item descriptions needs to be improved. I saw many typos too. Please go through all the descriptions and try to improve them.
|
@lifeart Ping |
@sindresorhus only contributing update need to be aligned, right? |
What I commented previously needs to be done. |
@sindresorhus other things like project description, typos, naming fixed |
@sindresorhus amazing news! Thank you! |
This PR updates Ember.js awesome list link
from: https://github.com/nmec/awesome-ember
to: https://github.com/ember-community-russia/awesome-ember
why?
ember-community-russia/awesome-ember
- actively maintaned,nmec/awesome-ember
- not