Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ember #1579

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Update Ember #1579

merged 1 commit into from
Sep 28, 2019

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Jun 30, 2019

This PR updates Ember.js awesome list link

from: https://github.com/nmec/awesome-ember
to: https://github.com/ember-community-russia/awesome-ember

why?

  • ember-community-russia/awesome-ember - actively maintaned, nmec/awesome-ember - not

@sindresorhus
Copy link
Owner

@leomaurodesenv
Copy link
Contributor

@lifeart, It seems very useful its update. Make a pull request!

Just a preview of the awesome-lint:

awesome-lint https://github.com/ember-community-russia/awesome-ember
...
298 errors

Common errors:

  • List item link and description must be separated with a dash.
  • List item description must end with proper punctuation.
  • Dead links.
  • Other markdown formatting errors.

@zoidyzoidzoid
Copy link
Contributor

One of the other things I noticed is no contributing guidelines.

You link to one though from the readme: https://github.com/ember-community-russia/awesome-ember/blob/master/contributing.md

@zoidyzoidzoid zoidyzoidzoid mentioned this pull request Jul 4, 2019
@lifeart
Copy link
Contributor Author

lifeart commented Jul 7, 2019

Tank you all for links & review!
Errors fixed, only 2 dead links (one - I beleve temporary network issue, second - I'm waiting for status feedback)

image

@sindresorhus
Copy link
Owner

Please read /pull_request_template.md@master

You have not read it fully.

@lifeart lifeart changed the title Update: Ember - fresh awesome link Update Ember Jul 27, 2019
@lifeart
Copy link
Contributor Author

lifeart commented Jul 27, 2019

unicorn

@irazasyed
Copy link
Contributor

@lifeart
✖ 630:3 Link to https://github.com/twokul/ember-cli-pact is dead

@irazasyed irazasyed mentioned this pull request Jul 27, 2019
@sindresorhus
Copy link
Owner

  README.md:515:3
  ✖   515:3  Link to https://github.com/freshbooks/ember-responsive is dead  remark-lint:no-dead-urls
  ✖   630:3  Link to https://github.com/twokul/ember-cli-pact is dead        remark-lint:no-dead-urls

@sindresorhus
Copy link
Owner

Includes a succinct description of the project/theme at the top of the readme. (Example)

Not done


https://github.com/ember-community-russia/awesome-ember/blob/master/contributing.md should be customized for your list and not just copy-pasted.


The repo description needs to be improved.


Consistent and correct naming. For example, Node.js, not NodeJS or node.js.

Not done


The item descriptions should not be in title case.


Many of the item descriptions needs to be improved. I saw many typos too. Please go through all the descriptions and try to improve them.

ember-cli-stylelint - Adds styleint to your ember app, to lint all kinds of css.

@sindresorhus
Copy link
Owner

@lifeart Ping

@lifeart
Copy link
Contributor Author

lifeart commented Sep 22, 2019

@sindresorhus only contributing update need to be aligned, right?

@sindresorhus
Copy link
Owner

What I commented previously needs to be done.

@lifeart
Copy link
Contributor Author

lifeart commented Sep 23, 2019

@sindresorhus other things like project description, typos, naming fixed

@sindresorhus sindresorhus merged commit 5ef7c0f into sindresorhus:master Sep 28, 2019
@sindresorhus
Copy link
Owner

Tweet: https://twitter.com/awesome__re/status/1177995437225074688

@lifeart
Copy link
Contributor Author

lifeart commented Sep 28, 2019

@sindresorhus amazing news! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants